Skip to content

Commit 5483eab

Browse files
always rethrow
1 parent 9c5705a commit 5483eab

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: precommit
22
Title: Pre-Commit Hooks
3-
Version: 0.3.2.9003
3+
Version: 0.3.2.9004
44
Author: Lorenz Walthert
55
Maintainer: Lorenz Walthert <[email protected]>
66
Description: Useful git hooks for R building on top of the multi-language

inst/hooks/exported/pkgdown-check.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,6 @@ tryCatch(
2323
build_articles_index()
2424
}
2525
},
26-
error = function(e) e,
26+
error = function(e) stop(e),
2727
warning = function(w) stop(w)
2828
)

tests/testthat/test-hooks.R

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -567,8 +567,7 @@ run_test("pkgdown-check",
567567
"_pkgdown.yml" = "_pkgdown-index.yml",
568568
"DESCRIPTION" = "DESCRIPTION"
569569
),
570-
suffix = "",
571-
error_msg = NULL
570+
suffix = "", std_err = NULL
572571
)
573572

574573
# failed index
@@ -579,7 +578,7 @@ run_test("pkgdown-check",
579578
"DESCRIPTION" = "DESCRIPTION"
580579
),
581580
suffix = "",
582-
error_msg = "topic must be a known"
581+
std_err = "topic must be a known"
583582
)
584583

585584
# failed articles
@@ -590,7 +589,7 @@ run_test("pkgdown-check",
590589
"DESCRIPTION" = "DESCRIPTION"
591590
),
592591
suffix = "",
593-
error_msg = "why-use-hooks"
592+
std_err = "why-use-hooks"
594593
)
595594

596595
# success index and article
@@ -602,7 +601,7 @@ run_test("pkgdown-check",
602601
"DESCRIPTION" = "DESCRIPTION"
603602
),
604603
suffix = "",
605-
error_msg = NULL
604+
std_err = NULL
606605
)
607606

608607

0 commit comments

Comments
 (0)