Skip to content

Commit 04515f3

Browse files
author
Max Rozenoer
authored
Support default json decoder even when nil responds to :load (#1563)
In Rails (some versions at least), nil responds to `:load` (via ActiveSupport::Dependencies::Loadable mixin). Enable default json decoder to work in this case
1 parent 6933e9b commit 04515f3

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

lib/faraday/response/json.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ def process_parser_options
6060
@decoder_options =
6161
if @decoder_options.is_a?(Array) && @decoder_options.size >= 2
6262
@decoder_options.slice(0, 2)
63-
elsif @decoder_options.respond_to?(:load)
63+
elsif @decoder_options&.respond_to?(:load) # rubocop:disable Lint/RedundantSafeNavigation
64+
# In some versions of Rails, `nil` responds to `load` - hence the safe navigation check above
6465
[@decoder_options, :load]
6566
else
6667
[::JSON, :parse]

spec/faraday/response/json_spec.rb

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,23 @@ def process(body, content_type = 'application/json', options = {})
184184
response = process(body)
185185
expect(response.body).to eq(result)
186186
end
187+
188+
it 'passes relevant options to JSON parse even when nil responds to :load' do
189+
original_allow_message_expectations_on_nil = RSpec::Mocks.configuration.allow_message_expectations_on_nil
190+
RSpec::Mocks.configuration.allow_message_expectations_on_nil = true
191+
allow(nil).to receive(:respond_to?)
192+
.with(:load)
193+
.and_return(true)
194+
195+
expect(JSON).to receive(:parse)
196+
.with(body, { symbolize_names: true })
197+
.and_return(result)
198+
199+
response = process(body)
200+
expect(response.body).to eq(result)
201+
ensure
202+
RSpec::Mocks.configuration.allow_message_expectations_on_nil = original_allow_message_expectations_on_nil
203+
end
187204
end
188205
end
189206
end

0 commit comments

Comments
 (0)