Fix: prevent storing heartbeat status logs in memory

Author: louisho5

internal/agent/tools/memory.go

@@ -155,6 +155,10 @@ func (t *EditMemoryTool) Execute(ctx context.Context, args map[string]interface{
 		return "", fmt.Errorf("edit_memory: 'old_text' argument required")
 	}
 	newText, _ := args["new_text"].(string) // defaults to "" (deletion) if absent
+	if isHeartbeatContent(newText) {
+		// return "", fmt.Errorf("edit_memory: heartbeat status logs must not be stored in memory — skip this edit")
+		return "", nil // skip sliently
+	}
 
 	name, err := resolveMemoryTarget(target)
 	if err != nil {

internal/agent/tools/write_memory.go

@@ -3,10 +3,35 @@ package tools
 import (
 	"context"
 	"fmt"
+	"strings"
 
 	"github.com/local/picobot/internal/agent/memory"
 )
 
+// heartbeatPhrases contains lowercase substrings that identify heartbeat-status
+// log entries. Any write_memory or edit_memory call whose content matches one
+// of these is rejected — the heartbeat loop must never pollute memory files.
+var heartbeatPhrases = []string{
+	"heartbeat check",
+	"heartbeat.md",
+	"heartbeat log",
+	"system status: healthy",
+	"no pending tasks",
+	"no actions required",
+	"periodic tasks",
+}
+
+// isHeartbeatContent returns true if content looks like a heartbeat status log.
+func isHeartbeatContent(content string) bool {
+	l := strings.ToLower(content)
+	for _, phrase := range heartbeatPhrases {
+		if strings.Contains(l, phrase) {
+			return true
+		}
+	}
+	return false
+}
+
 // WriteMemoryTool writes to the agent's memory (today's note or long-term MEMORY.md)
 type WriteMemoryTool struct {
 	mem *memory.MemoryStore
@@ -18,7 +43,7 @@ func NewWriteMemoryTool(mem *memory.MemoryStore) *WriteMemoryTool {
 
 func (w *WriteMemoryTool) Name() string { return "write_memory" }
 func (w *WriteMemoryTool) Description() string {
-	return "Write or append to memory (today's note or long-term MEMORY.md)"
+	return "Write or append to memory (today's note or long-term MEMORY.md). NEVER store heartbeat status, health checks, or 'no pending tasks' results."
 }
 
 func (w *WriteMemoryTool) Parameters() map[string]interface{} {
@@ -63,6 +88,9 @@ func (w *WriteMemoryTool) Execute(ctx context.Context, args map[string]interface
 	if !ok {
 		return "", fmt.Errorf("write_memory: 'content' must be a string")
 	}
+	if isHeartbeatContent(content) {
+		return "", fmt.Errorf("write_memory: heartbeat status logs must not be stored in memory — skip this write")
+	}
 	appendFlag := true
 	if a, ok := args["append"]; ok {
 		if b, ok := a.(bool); ok {
@@ -96,3 +124,4 @@ func (w *WriteMemoryTool) Execute(ctx context.Context, args map[string]interface
 		return "", fmt.Errorf("write_memory: unknown target '%s'", target)
 	}
 }
+

internal/agent/tools/write_memory_test.go

@@ -45,3 +45,28 @@ func TestWriteMemoryTool_TodayAndLong(t *testing.T) {
 		t.Fatalf("expected LT1 to be gone after overwrite, got %q", lt2)
 	}
 }
+
+func TestWriteMemoryTool_RejectsHeartbeatContent(t *testing.T) {
+	tmp := t.TempDir()
+	mem := memory.NewMemoryStoreWithWorkspace(tmp, 10)
+	w := NewWriteMemoryTool(mem)
+
+	cases := []string{
+		"HEARTBEAT CHECK: system status: HEALTHY",
+		"Reviewed HEARTBEAT.md. No pending tasks. System status: HEALTHY. No actions required.",
+		"heartbeat check complete",
+		"[2026-03-07T00:12:36Z] HEARTBEAT CHECK at 2026-03-06: no pending tasks",
+	}
+	for _, c := range cases {
+		_, err := w.Execute(context.Background(), map[string]interface{}{"target": "today", "content": c})
+		if err == nil {
+			t.Fatalf("expected heartbeat content to be rejected, but it was accepted: %q", c)
+		}
+	}
+
+	// Confirm that legitimate content is still accepted.
+	_, err := w.Execute(context.Background(), map[string]interface{}{"target": "today", "content": "user prefers dark mode"})
+	if err != nil {
+		t.Fatalf("expected legitimate content to be accepted, got: %v", err)
+	}
+}

internal/config/onboard.go

@@ -118,7 +118,8 @@ Never create files directly in the workspace root. Always use a project folder.
 - Use list_memory to see all available memory files
 - Use delete_memory to clean up outdated daily notes
 - Do NOT just say you'll remember something — actually call write_memory
-- Do NOT use write_memory tool for redundant information like heartbeat logs
+- NEVER write heartbeat results, health checks, or periodic status logs to memory — these are ephemeral and must be discarded after each run
+- Memory is for durable user knowledge only: facts, preferences, project notes, decisions
 
 ## Skills
 
@@ -270,6 +271,13 @@ Schedule or manage cron jobs.
 
 This file is checked periodically (every 60 seconds). Add tasks here that should run on a schedule.
 
+## IMPORTANT RULES FOR HEARTBEAT PROCESSING
+
+- After reviewing this file, take actions ONLY if there are explicit tasks listed below
+- If there are no tasks (or all tasks are complete), do NOTHING — do not send any message, do not call write_memory or any memory tool
+- NEVER log "heartbeat check complete", "system status: healthy", or any status message to memory files — these clutter memory with useless noise
+- Heartbeat results are ephemeral: process, act if needed, then stop silently
+
 ## Periodic Tasks
 
 <!-- Add tasks below. The agent will process them on each heartbeat check. -->