Metadata API: Remove Signed.bump_version() method

Remove `bump_version()` method, which is just an alias for "+= 1"
on the version attribute. For a slim low-level API it seems okay to
just directly access/modify the attribute.

The extra level of abstraction of "bumping a version" is more
appropriate for a repository library (see theupdateframework#1136).

This patch also removes a related unit test and updates another one
to directly do `(...).version +=`.

Signed-off-by: Lukas Puehringer <[email protected]>

Author: Lukas Puehringer

tests/test_api.py

@@ -260,9 +260,6 @@ def test_metadata_base(self) -> None:
         snapshot_path = os.path.join(self.repo_dir, "metadata", "snapshot.json")
         md = Metadata.from_file(snapshot_path)
 
-        self.assertEqual(md.signed.version, 1)
-        md.signed.bump_version()
-        self.assertEqual(md.signed.version, 2)
         self.assertEqual(md.signed.expires, datetime(2030, 1, 1, 0, 0))
 
         # Test is_expired with reference_time provided

tests/test_updater_ng.py

@@ -153,7 +153,7 @@ def _modify_repository_root(
         root = Metadata.from_file(role_path)
         modification_func(root)
         if bump_version:
-            root.signed.bump_version()
+            root.signed.version += 1
         root_key_path = os.path.join(self.keystore_directory, "root_key")
         root_key_dict = import_rsa_privatekey_from_file(
             root_key_path, password="password"

tuf/api/metadata.py

@@ -513,10 +513,6 @@ def is_expired(self, reference_time: Optional[datetime] = None) -> bool:
 
         return reference_time >= self.expires
 
-    def bump_version(self) -> None:
-        """Increments the metadata version number by 1."""
-        self.version += 1
-
 
 class Key:
     """A container class representing the public portion of a Key.