Merge pull request #1362 from luxonis/lnotspotl/xlinkin_lazy_allocation

XLinkIn lazy buffer allocation

Author: lnotspotl

cmake/Depthai/DepthaiDeviceSideConfig.cmake

@@ -2,7 +2,7 @@
 set(DEPTHAI_DEVICE_SIDE_MATURITY "snapshot")
 
 # "full commit hash of device side binary"
-set(DEPTHAI_DEVICE_SIDE_COMMIT "185b62d2d420d12e8558705e7ce4a022e7a499c5")
+set(DEPTHAI_DEVICE_SIDE_COMMIT "11b35efacca28894f2b3fc930a4b15d4b8a4213d")
 
 # "version if applicable"
 set(DEPTHAI_DEVICE_SIDE_VERSION "")

include/depthai/properties/internal/XLinkInProperties.hpp

@@ -16,9 +16,10 @@ struct XLinkInProperties : PropertiesSerializable<Properties, XLinkInProperties>
     std::string streamName;
 
     /**
-     * Maximum input data size
+     * Maximum input data size:
+     * NV12 --> 1.5 = (3/2) bytes per pixel, roughly 17.6MB for a 4032x3056 frame
      */
-    std::uint32_t maxDataSize = dai::device::XLINK_USB_BUFFER_MAX_SIZE;
+    std::uint32_t maxDataSize = ((4032 * 3056) * 3) / 2;
 
     /**
      * Number of frames in pool

tests/CMakeLists.txt

@@ -479,3 +479,7 @@ dai_set_test_labels(camera_test ondevice rvc2_all rvc4 ci)
 # VideoEncoder test
 dai_add_test(video_encoder_test src/ondevice_tests/video_encoder_test.cpp)
 dai_set_test_labels(video_encoder_test ondevice rvc2_all rvc4 ci)
+
+# XLinkIn test
+dai_add_test(xlink_test src/ondevice_tests/xlink_tests.cpp)
+dai_set_test_labels(xlink_test ondevice rvc2_all ci)

tests/src/ondevice_tests/xlink_tests.cpp

@@ -0,0 +1,35 @@
+#include <catch2/catch_all.hpp>
+#include <catch2/catch_test_macros.hpp>
+#include <depthai/depthai.hpp>
+#include <depthai/pipeline/node/internal/XLinkIn.hpp>
+
+#include <thread>
+#include <chrono>
+using namespace std::chrono_literals;
+
+TEST_CASE("XLinkIn lazy allocation test") {
+    dai::Pipeline p;
+    auto manip = p.create<dai::node::ImageManip>()->build();
+
+    auto xLinkInImage = p.create<dai::node::internal::XLinkIn>();
+    auto xLinkInConfig = p.create<dai::node::internal::XLinkIn>();
+
+    xLinkInImage->setMaxDataSize(1024 * 1024 * 1024); // 1GB per frame
+    xLinkInImage->setNumFrames(64);
+
+    xLinkInConfig->setMaxDataSize(1024 * 1024 * 1024); // 1GB per frame
+    xLinkInConfig->setNumFrames(64);
+
+    xLinkInImage->out.link(manip->inputImage);
+    xLinkInConfig->out.link(manip->inputConfig);
+
+    auto run = [&]() {
+        p.start();
+        std::this_thread::sleep_for(1s);
+    };
+
+    // Without lazy allocation, this will throw as all the above XLinkIn nodes
+    // would allocate all the frames at once.
+    REQUIRE_NOTHROW(p.build());
+    REQUIRE_NOTHROW(run());
+}