Skip to content

Cache cleaner detects file change, but GUI is unchanged? #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
swaibar opened this issue Jan 8, 2020 · 3 comments
Closed

Cache cleaner detects file change, but GUI is unchanged? #67

swaibar opened this issue Jan 8, 2020 · 3 comments
Labels
more-info-required Further information is requested

Comments

@swaibar
Copy link

swaibar commented Jan 8, 2020

image

I have made a change to vendor\magento\module-checkout\view\frontend\templates\cart\noItems.phtml (just as a test I am not advocating hacking the core) and although it appears to be picked up by the cache cleaner, when I reload the page my change isn't shown... what am I doing wrong please?

@Vinai
Copy link
Contributor

Vinai commented Jan 8, 2020

Since Magento 2.1 there is a bug that causes the full page cache records to be written to the var/cache directory instead of var/page_cache.
The bug is only "active" if the default Magento cache configuration is used.
The issue the bug causes is that the cache cleaner sometimes seem to not work (e.g. the full page cache is not cleaned, even though it says it is).

There is an easy workaround, namely removing all cache configuration from the default app/etc/env.php.
The bug only affects the default config with the file system cache backend. Redis or Varnish are not affected. The bug will be fixed in the (currently upcoming) Magento 2.3.4 release.

Possibly you are running into this bug?
Please post the cache section of your app/etc/env.php and your Magento version to confirm if this is it.

@Vinai
Copy link
Contributor

Vinai commented Jan 8, 2020

See #48 (comment) for another case where that happened.
Maybe I should add automatic detection of affected Magento versions...

@Vinai
Copy link
Contributor

Vinai commented Mar 13, 2020

Closing since no feedback from original author of the post, and since then I've implemented automatic detection of the bug, too.

@Vinai Vinai closed this as completed Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-info-required Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants