#31 Refactored the code & committed composer.lock

Author: Roman Glushko

app/code/Magento/CmsGraphQl/Model/Resolver/Cms/CmsPageDataProvider.php

@@ -19,33 +19,17 @@
  */
 class CmsPageDataProvider
 {
-    /**
-     * @var ServiceOutputProcessor
-     */
-    private $serviceOutputProcessor;
-
-    /**
-     * @var SerializerInterface
-     */
-    private $jsonSerializer;
-
     /**
      * @var CmsPageRepositoryInterface
      */
     private $cmsPageRepository;
 
     /**
      * @param CmsPageRepositoryInterface $cmsPageRepository
-     * @param ServiceOutputProcessor $serviceOutputProcessor
-     * @param SerializerInterface $jsonSerializer
      */
     public function __construct(
-        CmsPageRepositoryInterface $cmsPageRepository,
-        ServiceOutputProcessor $serviceOutputProcessor,
-        SerializerInterface $jsonSerializer
+        CmsPageRepositoryInterface $cmsPageRepository
     ) {
-        $this->serviceOutputProcessor = $serviceOutputProcessor;
-        $this->jsonSerializer = $jsonSerializer;
         $this->cmsPageRepository = $cmsPageRepository;
     }
 
@@ -92,54 +76,6 @@ private function processCmsPage(CmsPageInterface $cmsPageModel) : array
             'mate_keywords' => $cmsPageModel->getMetaKeywords(),
         ];
 
-        if (isset($cmsPageData['extension_attributes'])) {
-            $cmsPageData = array_merge($cmsPageData, $cmsPageData['extension_attributes']);
-        }
-
-        if (isset($cmsPageData['custom_attributes'])) {
-            $cmsPageData = array_merge($cmsPageData, $this->processCustomAttributes($cmsPageData['custom_attributes']));
-        }
-
         return $cmsPageData;
     }
-
-    /**
-     * @param array $customAttributes
-     *
-     * @return array
-     */
-    private function processCustomAttributes(array $customAttributes) : array
-    {
-        $processedCustomAttributes = [];
-
-        foreach ($customAttributes as $customAttribute) {
-            $isArray = false;
-            $customAttributeCode = $customAttribute['attribute_code'];
-            $customAttributeValue = $customAttribute['attribute_code'];
-
-            if (is_array($customAttributeValue)) {
-                $isArray = true;
-
-                foreach ($customAttributeValue as $attributeValue) {
-                    if (is_array($attributeValue)) {
-                        $processedCustomAttributes[$customAttributeCode] = $this->jsonSerializer->serialize(
-                            $customAttributeValue
-                        );
-                        continue;
-                    }
-                    $processedCustomAttributes[$customAttributeCode] = implode(',', $customAttributeValue);
-                    continue;
-                }
-            }
-
-            if ($isArray) {
-                continue;
-            }
-
-            $processedCustomAttributes[$customAttributeCode] = $customAttributeValue;
-        }
-
-        return $processedCustomAttributes;
-    }
-
 }

app/code/Magento/CmsGraphQl/Model/Resolver/CmsPage.php

@@ -7,19 +7,15 @@
 
 namespace Magento\CmsGraphQl\Model\Resolver;
 
-use Magento\Authorization\Model\UserContextInterface;
 use Magento\CmsGraphQl\Model\Resolver\Cms\CmsPageDataProvider;
-use Magento\Framework\GraphQl\Exception\GraphQlInputException;
-use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
-use Magento\CustomerGraphQl\Model\Resolver\Customer\CustomerDataProvider;
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\GraphQl\Config\Element\Field;
-use Magento\Framework\GraphQl\Exception\GraphQlAuthorizationException;
+use Magento\Framework\GraphQl\Exception\GraphQlInputException;
 use Magento\Framework\GraphQl\Exception\GraphQlNoSuchEntityException;
-use Magento\Framework\GraphQl\Query\Resolver\ContextInterface;
 use Magento\Framework\GraphQl\Query\Resolver\Value;
 use Magento\Framework\GraphQl\Query\Resolver\ValueFactory;
 use Magento\Framework\GraphQl\Query\ResolverInterface;
+use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
 
 /**
  * CMS page field resolver, used for GraphQL request processing.

app/code/Magento/CmsGraphQl/etc/module.xml

@@ -9,7 +9,6 @@
     <module name="Magento_CmsGraphQl">
         <sequence>
             <module name="Magento_Cms"/>
-            <module name="Magento_Authorization"/>
             <module name="Magento_GraphQl"/>
         </sequence>
     </module>