fix formatting, fix unused method param $isSynchronous

Author: Vasiliev.A

lib/internal/Magento/Framework/Communication/Config/Reader/XmlReader/Converter.php

@@ -130,15 +130,16 @@ protected function extractTopics($config)
                     $topicName,
                     $serviceMethod[ConfigParser::TYPE_NAME],
                     $serviceMethod[ConfigParser::METHOD_NAME],
-                    $handlers
+                    $handlers,
+                    $isSynchronous
                 );
             } elseif ($requestSchema && $responseSchema) {
                 $output[$topicName] = [
                     Config::TOPIC_NAME => $topicName,
                     Config::TOPIC_IS_SYNCHRONOUS => $isSynchronous ?? true,
                     Config::TOPIC_REQUEST => $requestSchema,
                     Config::TOPIC_REQUEST_TYPE => Config::TOPIC_REQUEST_TYPE_CLASS,
-                    Config::TOPIC_RESPONSE => $responseSchema,
+                    Config::TOPIC_RESPONSE => ($isSynchronous) ? $responseSchema: null,
                     Config::TOPIC_HANDLERS => $handlers
                 ];
             } elseif ($requestSchema) {

lib/internal/Magento/Framework/Communication/Config/ReflectionGenerator.php

@@ -81,6 +81,8 @@ public function generateTopicConfigForServiceMethod(
         $returnType = ($returnType != 'void' && $returnType != 'null') ? $returnType : null;
         if (!isset($isSynchronous)) {
             $isSynchronous = $returnType ? true : false;
+        } else {
+            $returnType = ($isSynchronous) ? $returnType : null;
         }
         return [
             Config::TOPIC_NAME => $topicName,
@@ -89,12 +91,13 @@ public function generateTopicConfigForServiceMethod(
             Config::TOPIC_REQUEST_TYPE => Config::TOPIC_REQUEST_TYPE_METHOD,
             Config::TOPIC_RESPONSE => $returnType,
             Config::TOPIC_HANDLERS => $handlers
-                ? : [self::DEFAULT_HANDLER => $methodMetadata[Config::SCHEMA_METHOD_HANDLER]]
+                ?: [self::DEFAULT_HANDLER => $methodMetadata[Config::SCHEMA_METHOD_HANDLER]]
         ];
     }
 
     /**
      * Generate topic name based on service type and method name.
+     *
      * Perform the following conversion:
      * \Magento\Customer\Api\RepositoryInterface + getById =>
      * magento.customer.api.repositoryInterface.getById