Prevent exception when option text converts to false

pmclain · pmclain · commit ed6a2fba850c · 2018-10-20T12:11:28.000-04:00
The function would incorrectly through an exception when the option text was
set to a string that would evaluate to false such as "0"

Fixes #13083
diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/OptionManagement.php b/app/code/Magento/Eav/Model/Entity/Attribute/OptionManagement.php
@@ -141,7 +141,7 @@ public function getItems($entityType, $attributeCode)
      */
     protected function validateOption($attribute, $optionId)
     {
-        if (!$attribute->getSource()->getOptionText($optionId)) {
+        if ($attribute->getSource()->getOptionText($optionId) === false) {
             throw new NoSuchEntityException(
                 __(
                     'The "%1" attribute doesn\'t include an option with "%2" ID.',

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ public function getItems($entityType, $attributeCode)`
`141`	`141`	`*/`
`142`	`142`	`protected function validateOption($attribute, $optionId)`
`143`	`143`	`{`
`144`		`- if (!$attribute->getSource()->getOptionText($optionId)) {`
	`144`	`+ if ($attribute->getSource()->getOptionText($optionId) === false) {`
`145`	`145`	`throw new NoSuchEntityException(`
`146`	`146`	`__(`
`147`	`147`	`'The "%1" attribute doesn\'t include an option with "%2" ID.',`