Skip to content

Possible to switch to a whole div using TAB key #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chalov-anton opened this issue Feb 20, 2020 · 2 comments
Closed

Possible to switch to a whole div using TAB key #973

chalov-anton opened this issue Feb 20, 2020 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@chalov-anton
Copy link
Contributor

chalov-anton commented Feb 20, 2020

Preconditions (*)

Magento 2.3.5-develop
Adobe-Stock-Integration 1.0.1-release

  1. Installed Magento with Adobe Stock Integration
  2. Select Enabled Adobe Stock- Yes in Stores -> Configuration -> System -> Adobe Stock Integration fieldset
  3. Do NOT configure Api Key and Client secret

Steps to reproduce (*)

  1. From Admin go to Content - Pages, click Add New Page
  2. Expand Content,click Show / Hide Editor, click Insert Image...
  3. Click Search Adobe Stock
  4. Switch between controllers using TAB key on keyboard

Expected result (*)

The whole div should not be selected as it is not a button or a field. The link to Configuration → System → Adobe Stock Integration should be selected
tab_link

Actual result (*)

At about tens switch, the whole Failed to authenticate to Adobe Stock API.
Please correct the API credentials in Configuration → System → Adobe Stock Integration.
div is selected
tab_please_correct
Hitting Enter key doesn't do anything

@chalov-anton chalov-anton added the bug Something isn't working label Feb 20, 2020
@drpayyne drpayyne self-assigned this Feb 25, 2020
@drpayyne
Copy link
Contributor

drpayyne commented Feb 25, 2020

Hi @chalov-anton, thanks for reporting the issue. Pressing enter key when the link is focussed does actually work for me and it takes me to the Admin Configuration panel.

@sivaschenko, is the div.masonry-image-grid supposed to have tabindex=-1? It currently has 0 as its value. The tabindex=0 property was added by me as part of magento/magento2#25991.

@chalov-anton
Copy link
Contributor Author

Hello @drpayyne

Yes, pressing Enter key, when the focus is on Configuration → System → Adobe Stock Integration, does work
It, obviously, doesn't work when the whole div is selected. There is no purpose of focusing (selecting) the whole div

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants