Skip to content

magentoDataFixture should allow to use Module Prefix - Integrations Test #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
larsroettig opened this issue Dec 5, 2018 · 3 comments
Closed
Assignees

Comments

@larsroettig
Copy link
Member

Description (*)

As a Developer, we have different solutions to install Magento and Setup Projects. Currently, if the test fixtures place in the app/code/Module_Name and is installed over composer is not possible to use annotations like Magento_InventoryApi::Test/_files/products.php

Expected behavior (*)

Module annotations like Magento_InventoryApi::Test/_files/products.php works and \Magento\TestFramework\Annotation\DataFixture find the correct path for Integrations Test

Benefits

As a developer, you can use the prefix to use data fixture from the core to test your own plugins and extensions

Additional information

    /**
     * Old Fixture File place in testsuite
     * @magentoDataFixture Magento/Customer/_files/customer.php
     *
     * New Fixture File place in app/code
     * @magentoDataFixture Magento_InventoryApi::Test/_files/products.php
     *
     * @magentoDbIsolation disabled
     */
    public function testValidation()
@magento-engcom-team
Copy link

magento-engcom-team commented Dec 5, 2018

Hi @larsroettig. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@larsroettig do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@larsroettig larsroettig self-assigned this Dec 5, 2018
@sdzhepa
Copy link

sdzhepa commented Dec 21, 2018

Hello @larsroettig

According to the label "feature request" that you have set, I am moving this ticket into Feature Request track

Thank you

@sdzhepa sdzhepa transferred this issue from magento/magento2 Dec 21, 2018
@magento-engcom-team
Copy link

Hi @larsroettig. Thank you for your report.
The issue has been fixed in magento/magento2#19679 by @larsroettig in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants