You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
-Contributor submits PR with complex code and tests: Improvement(base) 10 points + Complex(additional) 20 points + Test coverage(additional) 10 points = 40 points
16
+
-Contributor submits PR port of existing merged PR:
17
+
- Original contributor: (Improvement(base) 10 points + Complex(additional) 20 points) + Author of Ported Issue 5 points = 35 points
18
+
- Porting contributor: Port(base) 5 points
19
+
-Maintainer reviews and approves PR with complex code and tests: Improvement(base) 10 points + Complex(additional) 20 points + Test coverage(additional) 10 points = 40 points
20
20
21
21
Earned achievements display as labels on GitHub PRs and for each Magento Contributor, Partner, and Maintainer on [magento.com](https://magento.com/magento-contributors).
22
22
@@ -54,8 +54,8 @@ Contributors and Maintainers can also earn rewards for merged submissions to the
54
54
55
55
See the following examples for calculated reward points:
56
56
57
-
- Contributor submits PR with HTML formatting and typos fixes: Editorial(base) 1 point
58
-
- Contributor submits PR with code sample update and new parameter descriptions: Improvement(base) 10 points + Major update(additional) 20 points = 30 points
57
+
-Contributor submits PR with HTML formatting and typos fixes: Editorial(base) 1 point
58
+
-Contributor submits PR with code sample update and new parameter descriptions: Improvement(base) 10 points + Major update(additional) 20 points = 30 points
Copy file name to clipboardExpand all lines: _includes/php-dev/component-root-2.3.md
+6-6Lines changed: 6 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,14 +2,14 @@
2
2
3
3
A component's root directory matches the component's name and contains all its subdirectories and files. Based on how you installed Magento, you can put your component's root directory in one of two places:
4
4
5
-
*`<Magento install directory>/app`: This is the *recommended* location for component development. You can set up this environment by [Cloning the Magento 2 GitHub repository]({{page.baseurl}}/install-gde/prereq/dev_install.html).
5
+
*`<Magento install directory>/app`: This is the *recommended* location for component development. You can set up this environment by [Cloning the Magento 2 GitHub repository]({{page.baseurl}}/install-gde/prereq/dev_install.html).
6
6
7
-
* For modules, use `app/code`.
8
-
* For storefront themes, use `app/design/frontend`.
9
-
* For Admin themes, use `app/design/adminhtml`.
10
-
* For language packages, use `app/i18n`.
7
+
* For modules, use `app/code`.
8
+
* For storefront themes, use `app/design/frontend`.
9
+
* For Admin themes, use `app/design/adminhtml`.
10
+
* For language packages, use `app/i18n`.
11
11
12
-
*`<Magento install directory>/vendor`: You will find this location for installations that use the [`composer create-project`]({{page.baseurl}}/install-gde/composer.html) to install the Magento 2 metapackage (which downloads the CE or EE code). You will also find this location if you install Magento by extracting the [compressed Magento 2 archive]({{page.baseurl}}/install-gde/prereq/zip_install.html).
12
+
*`<Magento install directory>/vendor`: You will find this location for installations that use the [`composer create-project`]({{page.baseurl}}/install-gde/composer.html) to install the Magento 2 metapackage (which downloads the CE or EE code). You will also find this location if you install Magento by extracting the [compressed Magento 2 archive]({{page.baseurl}}/install-gde/prereq/zip_install.html).
13
13
14
14
Magento installs third-party components in the `vendor` directory. But we recommend adding your components to the `app/code` directory. If you put your component in the `vendor` directory, Git will ignore it because Magento adds the `vendor` directory to the `.gitignore` file.
Copy file name to clipboardExpand all lines: _includes/php-dev/component-root.md
+6-6Lines changed: 6 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,14 +2,14 @@
2
2
3
3
A component's root directory is the top-level directory for that component under which its folders and files are located. Depending on how your Magento development environment was installed, your component's root directory can be located in two places:
4
4
5
-
*`<Magento install directory>/app`: This is the *recommended* location for component development. You can easily set up this type of environment by [Cloning the Magento 2 GitHub repository]({{ page.baseurl }}/install-gde/prereq/dev_install.html).
5
+
*`<Magento install directory>/app`: This is the *recommended* location for component development. You can easily set up this type of environment by [Cloning the Magento 2 GitHub repository]({{ page.baseurl }}/install-gde/prereq/dev_install.html).
6
6
7
-
* For modules, use `app/code`.
8
-
* For storefront themes, use `app/design/frontend`.
9
-
* For Admin themes, use `app/design/adminhtml`.
10
-
* For language packages, use `app/i18n`.
7
+
* For modules, use `app/code`.
8
+
* For storefront themes, use `app/design/frontend`.
9
+
* For Admin themes, use `app/design/adminhtml`.
10
+
* For language packages, use `app/i18n`.
11
11
12
-
*`<Magento install directory>/vendor`: This location is found in the alternative setups where the {% if page.guide_version == "2.0" %} [`composer create-project`]({{page.baseurl}}/install-gde/prereq/integrator_install.html) {% else %} [`composer create-project`]({{page.baseurl}}/install-gde/composer.html). {% endif %} command was used to get a Magento 2 metapackage (which downloads the CE or EE code), or a [compressed Magento 2 archive]({{ page.baseurl }}/install-gde/prereq/zip_install.html) was extracted in order to install Magento.
12
+
*`<Magento install directory>/vendor`: This location is found in the alternative setups where the {% if page.guide_version == "2.0" %} [`composer create-project`]({{page.baseurl}}/install-gde/prereq/integrator_install.html) {% else %} [`composer create-project`]({{page.baseurl}}/install-gde/composer.html). {% endif %} command was used to get a Magento 2 metapackage (which downloads the CE or EE code), or a [compressed Magento 2 archive]({{ page.baseurl }}/install-gde/prereq/zip_install.html) was extracted in order to install Magento.
13
13
14
14
Any third party components (and the Magento application itself) are downloaded and stored under the `vendor` directory. If you are using Git to manage project, this directory is typically added to the `.gitignore` file. Therefore, we recommend you do your customization work in `app/code`, not `vendor`.
*`<your component base dir>` is the base directory in which your component is located. Typical values are `app/code` or `vendor` relative to the Magento installation directory.
4
-
*`<vendorname>` is the component's vendor name; for example, Magento's vendor name is `magento`.
5
-
*`<component-type>` is one of the following:
3
+
*`<your component base dir>` is the base directory in which your component is located. Typical values are `app/code` or `vendor` relative to the Magento installation directory.
4
+
*`<vendorname>` is the component's vendor name; for example, Magento's vendor name is `magento`.
5
+
*`<component-type>` is one of the following:
6
6
7
-
*`module-`: An extension or module.
8
-
*`theme-`: Theme.
9
-
*`language-`: Language package.
7
+
*`module-`: An extension or module.
8
+
*`theme-`: Theme.
9
+
*`language-`: Language package.
10
10
11
11
{:.bs-callout .bs-callout-info}
12
12
Currently, themes are located under `<magento_root>/app/design/frontend` or `<magento_root>/app/design/adminhtml`.
Copy file name to clipboardExpand all lines: community/resources/multi-repo-docs.md
+9-9Lines changed: 9 additions & 9 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -14,13 +14,13 @@ This is the first of many new options for expanding documentation for developers
14
14
15
15
You get to:
16
16
17
-
- Keep your doc files in the same repo as your code.
18
-
- Manage doc updates by following the same GitHub processes you use for your code.
17
+
-Keep your doc files in the same repo as your code.
18
+
-Manage doc updates by following the same GitHub processes you use for your code.
19
19
20
20
The DevDocs team :
21
21
22
-
- Reviews, edits, and formats your docs.
23
-
- Automates content publishing using our CI/CD process, without moving your files.
22
+
-Reviews, edits, and formats your docs.
23
+
-Automates content publishing using our CI/CD process, without moving your files.
24
24
25
25
## How does it work?
26
26
@@ -29,10 +29,10 @@ The DevDocs team :
29
29
1. Create a `docs` directory in the root of your public repository. If you have images, add an `images` sudirectory.
30
30
1. Write simple markdown (`.md`) files using [kramdown](https://kramdown.gettalong.org/syntax.html).
31
31
1. Contact [Lori Krell](mailto:lkrell@adobe.com) in Community Engineering with the following details:
32
-
- Project name or feature
33
-
- GitHub Repository link
34
-
- Contact for your project
35
-
- Any additional information such as type of content, labels used for doc issues, if you need diagrams, and so on
32
+
- Project name or feature
33
+
- GitHub Repository link
34
+
- Contact for your project
35
+
- Any additional information such as type of content, labels used for doc issues, if you need diagrams, and so on
36
36
37
37
## What happens next?
38
38
@@ -53,4 +53,4 @@ To ensure quality documentation, your content must pass a quality review and acc
53
53
54
54
Use any IDE to write content. All IDEs support markdown files (.md), including extensions that check formatting as you write. We recommend using [Kramdown](https://kramdown.gettalong.org/syntax.html), which includes markdown formatting.
55
55
56
-
We will add more technical information as we release Multi-Repo Doc support and features.
56
+
We will add more technical information as we release Multi-Repo Doc support and features.
- Enter your [authentication keys]({{ site.baseurl }}/guides/v{{ site.version }}/install-gde/prereq/connect-auth.html). Your public key is your username; your private key is your password.
35
-
- Wait for Composer to finish updating your project dependencies and make sure there aren’t any errors.
34
+
- Enter your [authentication keys]({{ site.baseurl }}/guides/v{{ site.version }}/install-gde/prereq/connect-auth.html). Your public key is your username; your private key is your password.
35
+
- Wait for Composer to finish updating your project dependencies and make sure there aren’t any errors.
36
36
1. After installing, enter an [API Key](https://docs.magento.com/m2/ce/user_guide/sales-channels/amazon/amazon-verify-api-key.html) to complete configuration.
37
37
38
38
## Add the Amazon Sales Channel API key
@@ -43,23 +43,23 @@ To add the Amazon Sales Channel API key:
43
43
44
44
1. On the Admin sidebar, click **Marketing**. Then under **Channels**, click **Amazon**.
45
45
46
-
If you need an API Key, the following screen displays.
46
+
If you need an API Key, the following screen displays.
47
47
48
-
48
+
49
49
50
50
1. Click **Sign in** to access your Magento web account. The [Magento Accounts](https://account.magento.com/customer/account/login) page loads, displaying the **API Portal** tab.
51
51
52
-
You may need to login with your Magento web account credentials. If you need to create an account, visit [here](https://account.magento.com/customer/account/login) and register.
52
+
You may need to login with your Magento web account credentials. If you need to create an account, visit [here](https://account.magento.com/customer/account/login) and register.
53
53
54
54
1. API keys are available through the **API Portal** tab. Copy the key.
55
55
56
-
If you need to create a new key, enter a description like "Amazon Sales Channel" and click **Add**. Copy this new key.
56
+
If you need to create a new key, enter a description like "Amazon Sales Channel" and click **Add**. Copy this new key.
57
57
58
-
58
+
59
59
60
60
1. Return to the Magento Admin tab and click **Add the key** on the Amazon welcome screen.
61
61
62
-
A store configuration page opens to **Stores**>**Configuration**>**Services**>**Magento Services**.
62
+
A store configuration page opens to **Stores**>**Configuration**>**Services**>**Magento Services**.
63
63
64
64
1. On the Api Keys screen, paste the key you copied for**Production API Key**.
Copy file name to clipboardExpand all lines: guides/v2.2/architecture/archi_perspectives/domain_layer.md
+8-8Lines changed: 8 additions & 8 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -8,9 +8,9 @@ menu_title: Domain layer
8
8
9
9
The [domain](https://glossary.magento.com/domain) layer holds the business logic layer of a Magento [module](https://glossary.magento.com/module). It typically does not contain resource-specific or database-specific information. Its primary functions include:
10
10
11
-
* Defining the generic Magento data objects, or models, that contain business logic. This logic defines which operations can be performed on particular types of data, such as a Customer object. These models contain generic information only. Applications can also use SOAP or RESTful endpoints to request data from models.
11
+
*Defining the generic Magento data objects, or models, that contain business logic. This logic defines which operations can be performed on particular types of data, such as a Customer object. These models contain generic information only. Applications can also use SOAP or RESTful endpoints to request data from models.
12
12
13
-
* (Optionally) Including the implementation of service contracts, although not their definition.
13
+
*(Optionally) Including the implementation of service contracts, although not their definition.
14
14
15
15
{:.bs-callout .bs-callout-tip}
16
16
**Best practice:** Use service contracts to communicate with the domain layer by passing data types through strongly typed objects. This helps you avoid the need to replace presentation layer code when replacing business layer logic.
@@ -23,17 +23,17 @@ Each domain-layer model contains a reference to a resource model, which it uses
23
23
24
24
There are three primary ways of accessing a module's domain-layer code:
25
25
26
-
* Service contracts are the recommended way for one module to access another module's domain-level code. This loosely coupled solution is the optimal way for most modules to access another module.
26
+
*Service contracts are the recommended way for one module to access another module's domain-level code. This loosely coupled solution is the optimal way for most modules to access another module.
27
27
28
-
* A module can directly call into another module. This tightly coupled solution is not recommended for most situations, but is sometimes unavoidable.
28
+
*A module can directly call into another module. This tightly coupled solution is not recommended for most situations, but is sometimes unavoidable.
29
29
30
-
* Domain layer code in one module can also plug itself into another module by:
30
+
*Domain layer code in one module can also plug itself into another module by:
31
31
32
-
* event hooks
32
+
* event hooks
33
33
34
-
* plugins
34
+
* plugins
35
35
36
-
*`di.xml` files (with an SPI contract)
36
+
*`di.xml` files (with an SPI contract)
37
37
38
38
Your strategy for calling another module's domain-layer code is highly dependent upon the unique configuration and needs of your system.
0 commit comments