Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Commit 95ce5a5

Browse files
Markdown linting: Enable rule MD032 (lists should be surrounded by blank lines) (#5957)
* Fixed all obvious errors * Fixed false positives
1 parent bd8f044 commit 95ce5a5

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+6451
-92
lines changed

_checks/styles/style-rules-prod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ exclude_rule 'MD028'
2525
rule 'MD029'
2626
rule 'MD030', :ul_single => 2, :ol_single => 1, :ul_multi => 2, :ol_multi => 1
2727
exclude_rule 'MD031'
28-
exclude_rule 'MD032'
28+
rule 'MD032'
2929
exclude_rule 'MD033'
3030
exclude_rule 'MD034'
3131
rule 'MD035'

_includes/config/setup-cron_2.2_about.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,6 @@ Magento uses cron for two sets of tasks, and for each, cron can run with a diffe
99
* Web server PHP plug-in configuration: Two other cron jobs are used by the [Component Manager and System Upgrade utilities]({{ page.baseurl }}/comp-mgr/bk-compman-upgrade-guide.html).
1010

1111
{: .bs-callout-warning }
12+
1213
* To avoid issues during installation and upgrade, we strongly recommend you apply the same PHP settings to both the PHP command-line configuration and to the PHP web server plug-in's configuration. For more information, see [Required PHP settings]({{ page.baseurl }}/install-gde/prereq/php-settings.html).
1314
* In a multi-node system, crontab can run on only one node. This applies to you only if you set up more than one webnode for reasons related to performance or scalability.

_includes/config/setup-cron_2.2_how-to.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ To create the Magento crontab:
1717
Use `--force` to rewrite an existing Magento crontab.
1818

1919
{: .bs-callout-info }
20+
2021
* `magento cron:install` does not rewrite an existing crontab inside `#~ MAGENTO START` and `#~ MAGENTO END` comments in your crontab.
2122
* `magento cron:install --force` has no effect on any cron jobs outside the Magento comments.
2223

_includes/config/setup-cron_2.3_how-to.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ To create the Magento crontab:
1717
Use `--force` to rewrite an existing Magento crontab.
1818

1919
{: .bs-callout-info }
20+
2021
* `magento cron:install` does not rewrite an existing crontab inside `#~ MAGENTO START` and `#~ MAGENTO END` comments in your crontab.
2122
* `magento cron:install --force` has no effect on any cron jobs outside the Magento comments.
2223

guides/v2.2/cloud/cdn/trouble-fastly.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,14 +212,17 @@ Verify that the returned response contains the following information:
212212
The following excerpt from the cURL command output shows the correct values for the `Pragma`, `X-Magento-Tags`, and `Fastly-Module-Enabled` headers:
213213

214214
```terminal
215+
215216
* STATE: INIT => CONNECT handle 0x600057800; line 1402 (connection #-5000)
216217
* Rebuilt URL to: https://www.mymagento.biz.c.sv7gVom4qrpek.ent.magento.cloud/
217218
* Added connection 0. The cache now contains 1 members
218219
* Trying 192.0.2.31...
219220
* STATE: CONNECT => WAITCONNECT handle 0x600057800; line 1455 (connection #0)
221+
220222
% Total % Received % Xferd Average Speed Time Time Time Current
221223
Dload Upload Total Spent Left Speed
222224
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0* Connected to www.mymagento.biz.c.sv7gVom4qrpek.ent.magento.cloud (54.229.163.31) port 443 (#0)
225+
223226
* STATE: WAITCONNECT => SENDPROTOCONNECT handle 0x600057800; line 1562 (connection #0)
224227
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0* ALPN, offering h2
225228
@@ -242,6 +245,7 @@ The following excerpt from the cURL command output shows the correct values for
242245
* multi_done
243246
0 0 0 0 0 0 0 0 --:--:-- 0:00:02 --:--:-- 0
244247
* Connection #0 to host www.mymagento.biz.c.sv7gVom4qrpek.ent.magento.cloud left intact
248+
245249
```
246250
247251
{: .bs-callout-info }

guides/v2.2/cloud/composer-packages/ece-patches.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,11 @@ Implemented version-based patching. Now the package is compatible with {{site.da
4545
### Fixed issues
4646

4747
<!--MAGECLOUD-1033-->
48+
4849
- Removed patch; fixing bug in `colinmollenhour/credis` v1.6 to enable support for {{site.data.var.ece}} 2.2.1.
4950

5051
## v102.0.0
52+
5153
{:.bs-callout .bs-callout-warning}
5254
This package is no longer compatible with other versions of {{site.data.var.ece}} and **should not** be used.
5355

guides/v2.2/cloud/release-notes/CloudReleaseNotes2.2.1.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,13 @@ In general, we’ve removed serialize/unserialize from most the code to improve
3333
### New Updates
3434

3535
<!--- MAGECLOUD-1057 -->
36+
3637
* Magento Commerce (Cloud) supports scopes and [static content deployment strategies]({{ site.baseurl }}/guides/v2.2/config-guide/cli/config-cli-subcommands-static-deploy-strategies.html). We have added the `–s` parameter with a default setting of quick for the static content deployment strategy. You can use the environment variable [SCD_STRATEGY]({{ site.baseurl }}/guides/v2.2/cloud/env/environment-vars_magento.html) to customize and use these strategies with your build and deploy actions. This variable supports the options standard quick, or compact. If you select compact, we override the `STATIC_CONTENT_THREADS` value with 1, which can slow deployment, especially in production environments.
3738

3839
* When you create a new project, we automatically provision the project with the latest Magento Commerce (Cloud) code. The steps include cloning the latest code repository, adding an environment variable for `ADMIN_EMAIL` using the License Owner’s email, setting a default randomized Magento Admin password, and sending emails to the License Owner to access the project and reset the default Magento Admin password. For details, see [Onboarding tasks]({{ site.baseurl }}/guides/v2.2/cloud/onboarding/onboarding-tasks.html).
3940

4041
<!--- MAGECLOUD-1014, 1023 -->
42+
4143
* We have created a new log file on environments to capture and compile build and deploy actions. The file is located in the `app/var/log/cloud.log` file inside the Magento root application directory.
4244

4345
## Known issues {#known}
@@ -47,9 +49,11 @@ For all known {{site.data.var.ee}} 2.2.1 issues, see [Magento Commerce 2.2.1 Re
4749
## Fixed issues {#fixed}
4850

4951
<!-- MAGECLOUD-1355 -->
52+
5053
* You can now [manually reset stuck Magento cron jobs]({{ site.baseurl }}/guides/v2.2/cloud/trouble/reset-cron-jobs.html) using a CLI command in all environments via SSH access. The deployment process automatically resets cron jobs. You must [patch magento/ece-tools]({{ site.baseurl }}/guides/v2.2/cloud/project/project-patch.html) to get this update.
5154

5255
<!--- MAGECLOUD-1121 -->
56+
5357
* We resolved an issue with the ElasticSearch option being added and saved to `app/etc/env.php`. When ElasticSearch is configured and activated in your environment, the setting properly saves in the `env.php` file. For example:
5458

5559
<code><?php

guides/v2.2/cloud/release-notes/CloudReleaseNotes2.2.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,18 +58,23 @@ For all known {{site.data.var.ee}} 2.2.0 GA issues, see [Magento Commerce 2.2.0
5858
This release contains numerous fixes and enhancements. This section includes only fixes for {{site.data.var.ece}}. For all known {{site.data.var.ee}} 2.2.0 GA issues, see [Magento Commerce 2.2.0 Release Notes]({{ site.baseurl }}/guides/v2.2/release-notes/ReleaseNotes2.2.0EE.html).
5959

6060
<!--RFC-125-->
61+
6162
* We removed `var/view_preprocessed` symlinking to fix an issue that was causing JavaScript minification conflicts.
6263

6364
<!-- MAGECLOUD-1355 -->
65+
6466
* You can now [manually reset stuck Magento cron jobs]({{ site.baseurl }}/guides/v2.2/cloud/trouble/reset-cron-jobs.html) using a CLI command in all environments via SSH access. The deployment process automatically resets cron jobs. You must [patch magento/ece-tools]({{ site.baseurl }}/guides/v2.2/cloud/project/project-patch.html) to get this update.
6567

6668
<!-- 57167 -->
69+
6770
* You can now generate sitemap.xml and robots.txt normally through the Magento Admin panel, without needing to move the file and have a redirect entered. If you are upgrading to 2.2, please enter a [Support ticket] to have any redirects removed for sitemap and robots.txt.
6871

6972
<!-- MAGECLOUD-894 -->
73+
7074
* Newly provisioned {{site.data.var.ece}} receive an email to change the Magento Admin password. For enhanced security, we generate a random password for the username "admin" and send an email to the Project Owner to properly set up Admin access for Starter `master` Production environment and the Pro Integration `master` environment.
7175

7276
<!-- MAGECLOUD-1025 MAGECLOUD-930 -->
77+
7378
* We added additional environment variables and updated build and deploy hooks to [`.magento.app.yaml`]({{ site.baseurl }}/guides/v2.2/cloud/project/project-conf-files_magento-app.html).
7479

7580
* When upgrading to {{site.data.var.ece}} 2.2.0, you will need to update your `.magento.app.yaml` file and Configuration Management `config.local.php` file. See [Upgrade Magento Commerce (Cloud)]({{ site.baseurl }}/guides/v2.2/cloud/project/project-upgrade.html).
@@ -79,12 +84,15 @@ This release contains numerous fixes and enhancements. This section includes onl
7984
* We’ve added support for the latest version of Redis and for PHP-Redis 3.1.3. For more information on this update, and for guidance on Redis troubleshooting on {{site.data.var.ece}}, see [Redis troubleshooting]({{ site.baseurl }}/guides/v2.2/cloud/trouble/redis-troubleshooting.html).
8085

8186
<!--- 55462/52448-->
87+
8288
* Magento now correctly displays customer address during account creation. Previously, when you selected a default billing address during creation of a new customer account, Magento would not display the address.
8389

8490
<!---61104 -->
91+
8592
* When you delete an image in Admin, Magento no longer deletes it on the server. Previously, Magento deleted it from the server as well, which caused errors for other products (example error message: `Cannot gather stats! Warning!stat(): stat failed for`).
8693

8794
<!--- 68833 -->
95+
8896
* We’ve fixed errors in processing valid orders using a PayPal account that had been previously used to pay for a valid order that had problems during checkout.
8997

9098
## Changes in Deployment {#deploy}

guides/v2.2/mrg/ce/Signifyd.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ The following interfaces (marked with the `@api` annotation) extend the Signifyd
4545
- send a request through the Signifyd API to create a new case guarantee
4646

4747
`Magento\Signifyd\Api\GuaranteeCancelingServiceInterface`:
48+
4849
- send a request through the Signifyd API to cancel the Signifyd case guarantee
4950

5051
`Magento\Signifyd\Api\Data\CaseSearchResultsInterface`:

guides/v2.2/pattern-library/general/accessibilityguideline/accessibilityGuideline.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@ The Magento application should be accessible for all people, whatever their hard
88

99
- **Be mindful of text length**—Don't make textual content too long or too short.
1010

11-
- **Provide adequate contrast**—Be extra careful with light shades of gray, orange, and yellow. Check your contrast levels here:
12-
[http://webaim.org/resources/contrastchecker/](http://webaim.org/resources/contrastchecker/){:target="_blank"}
13-
or here: [http://www.paciellogroup.com/resources/contrastAnalyser](http://www.paciellogroup.com/resources/contrastAnalyser){:target="_blank"}
11+
- **Provide adequate contrast**—Be extra careful with light shades of gray, orange, and yellow. Check your contrast levels here: [http://webaim.org/resources/contrastchecker/](http://webaim.org/resources/contrastchecker/){:target="_blank"} or here: [http://www.paciellogroup.com/resources/contrastAnalyser](http://www.paciellogroup.com/resources/contrastAnalyser){:target="_blank"}
1412

1513
**Acceptable**
1614

0 commit comments

Comments
 (0)