Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Commit e221e8a

Browse files
yogeshksbdenham
authored andcommitted
Remove extra space and close <image> tag (#1920)
1 parent 93a509d commit e221e8a

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

guides/v2.0/frontend-dev-guide/themes/admin_theme_create.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Configure it using the following example (replace placeholders with your {% glos
4646
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Config/etc/theme.xsd">
4747
<title>%Theme title%</title> <!-- your theme's name -->
4848
<parent>%vendor_dir%/%parent_theme_dir%</parent> <!-- the parent theme. Example: Magento/backend -->
49-
</theme>
49+
</theme>
5050
{%endhighlight%}
5151

5252
If you change the theme title or parent theme information in `theme.xml` after a theme was already [registered](#register_theme), you need to open or reload any {% glossarytooltip 18b930cf-09cc-47c9-a5e5-905f86c43f81 %}Magento Admin{% endglossarytooltip %} page for your changes to be saved in the database.

guides/v2.0/frontend-dev-guide/themes/theme-inherit.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ the Orange theme by OrangeCo inherits from the Magento Blank theme. The inherita
4040
<media>
4141
<preview_image>media/preview.jpg</preview_image>
4242
</media>
43-
</theme>
43+
</theme>
4444
{% endhighlight xml %}
4545

4646
<div class="bs-callout bs-callout-info" id="info">
@@ -115,15 +115,15 @@ For example, if you must override the `<Magento_Catalog_module_dir>/view/fronten
115115

116116
<u>Example</u>
117117
By default, according to the module template, in the mini {% glossarytooltip c7ecb18d-cefe-452d-83e2-3c4d5e355db9 %}shopping cart{% endglossarytooltip %} products are listed under the Go to {% glossarytooltip 278c3ce0-cd4c-4ffc-a098-695d94d73bde %}Checkout{% endglossarytooltip %} button:
118-
<p><img src="{{ site.baseurl }}/common/images/inherit_mini1.png" alt="In the minishopping cart products are listed under the Go to Checkout button "></p>
118+
<p><img src="{{ site.baseurl }}/common/images/inherit_mini1.png" alt="In the minishopping cart products are listed under the Go to Checkout button"/></p>
119119

120120
The order is defined in the `<Magento_Checkout_module_dir>/view/frontend/templates/cart/minicart.phtml` module template. The Blank theme does not override this template.
121121
OrangeCo decided they want the product list to be displayed before the Go to Checkout button.
122122
To do this, they need to add an overriding template for the corresponding module in the Orange theme folder:
123123
`app/design/frontend/OrangeCo/orange/Magento_Checkout/templates/cart/minicart.phtml`
124124
Note, that the path to the template inside the `templates` directory in the theme corresponds to that in the module.
125125
Having changed the order or elements in the templates, OrangeCo got the minicart look like following:
126-
<p><img src="{{ site.baseurl }}/common/images/inherit_mini2.png" alt="In the minishopping cart products are listed above the Go to Checkout button "></p>
126+
<p><img src="{{ site.baseurl }}/common/images/inherit_mini2.png" alt="In the minishopping cart products are listed above the Go to Checkout button"/></p>
127127
You can find out what exactly code changes are required to perform this and other tasks in the <a href="{{ page.baseurl }}/frontend-dev-guide/templates/template-sample.html">Illustration of customizing templates topic</a>.
128128

129129
## Extend layouts {#theme-inherit-layout}

guides/v2.1/frontend-dev-guide/themes/admin_theme_create.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Configure it using the following example (replace placeholders with your {% glos
4646
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Config/etc/theme.xsd">
4747
<title>%Theme title%</title> <!-- your theme's name -->
4848
<parent>%vendor_dir%/%parent_theme_dir%</parent> <!-- the parent theme. Example: Magento/backend -->
49-
</theme>
49+
</theme>
5050
{%endhighlight%}
5151

5252
If you change the theme title or parent theme information in `theme.xml` after a theme was already [registered](#register_theme), you need to open or reload any {% glossarytooltip 18b930cf-09cc-47c9-a5e5-905f86c43f81 %}Magento Admin{% endglossarytooltip %} page for your changes to be saved in the database.

guides/v2.1/frontend-dev-guide/themes/theme-inherit.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ the Orange theme by OrangeCo inherits from the Magento Blank theme. The inherita
4040
<media>
4141
<preview_image>media/preview.jpg</preview_image>
4242
</media>
43-
</theme>
43+
</theme>
4444
{% endhighlight xml %}
4545

4646
<div class="bs-callout bs-callout-info" id="info">
@@ -113,15 +113,15 @@ For example, if you must override the `<Magento_Catalog_module_dir>/view/fronten
113113

114114
<u>Example</u>
115115
By default, according to the module template, in the mini {% glossarytooltip c7ecb18d-cefe-452d-83e2-3c4d5e355db9 %}shopping cart{% endglossarytooltip %} products are listed under the Go to {% glossarytooltip 278c3ce0-cd4c-4ffc-a098-695d94d73bde %}Checkout{% endglossarytooltip %} button:
116-
<p><img src="{{ site.baseurl }}/common/images/inherit_mini1.png" alt="In the minishopping cart products are listed under the Go to Checkout button "></p>
116+
<p><img src="{{ site.baseurl }}/common/images/inherit_mini1.png" alt="In the minishopping cart products are listed under the Go to Checkout button"/></p>
117117

118118
The order is defined in the `<Magento_Checkout_module_dir>/view/frontend/templates/cart/minicart.phtml` module template. The Blank theme does not override this template.
119119
OrangeCo decided they want the product list to be displayed before the Go to Checkout button.
120120
To do this, they need to add an overriding template for the corresponding module in the Orange theme folder:
121121
`app/design/frontend/OrangeCo/orange/Magento_Checkout/templates/cart/minicart.phtml`
122122
Note, that the path to the template inside the `templates` directory in the theme corresponds to that in the module.
123123
Having changed the order or elements in the templates, OrangeCo got the minicart look like following:
124-
<p><img src="{{ site.baseurl }}/common/images/inherit_mini2.png" alt="In the minishopping cart products are listed above the Go to Checkout button "></p>
124+
<p><img src="{{ site.baseurl }}/common/images/inherit_mini2.png" alt="In the minishopping cart products are listed above the Go to Checkout button"/></p>
125125
You can find out what exactly code changes are required to perform this and other tasks in the <a href="{{ page.baseurl }}/frontend-dev-guide/templates/template-sample.html">Illustration of customizing templates topic</a>.
126126

127127
## Extend layouts {#theme-inherit-layout}

0 commit comments

Comments
 (0)