Use another fixture for api-functional tests

Author: rogyar

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/CouponTest.php

@@ -43,11 +43,11 @@ protected function setUp()
 
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_simple_product_saved.php
-     * @magentoApiDataFixture Magento/SalesRule/_files/coupon_cart_fixed_discount.php
+     * @magentoApiDataFixture Magento/SalesRule/_files/coupon_code_with_wildcard.php
      */
     public function testApplyCouponToGuestCartWithItems()
     {
-        $couponCode = 'CART_FIXED_DISCOUNT_15';
+        $couponCode = '2?ds5!2d';
 
         $this->quoteResource->load(
             $this->quote,
@@ -64,11 +64,11 @@ public function testApplyCouponToGuestCartWithItems()
 
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_simple_product_saved.php
-     * @magentoApiDataFixture Magento/SalesRule/_files/coupon_cart_fixed_discount.php
+     * @magentoApiDataFixture Magento/SalesRule/_files/coupon_code_with_wildcard.php
      */
     public function testApplyCouponTwice()
     {
-        $couponCode = 'CART_FIXED_DISCOUNT_15';
+        $couponCode = '2?ds5!2d';
 
         $this->quoteResource->load(
             $this->quote,
@@ -88,11 +88,11 @@ public function testApplyCouponTwice()
 
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/active_quote.php
-     * @magentoApiDataFixture Magento/SalesRule/_files/coupon_cart_fixed_discount.php
+     * @magentoApiDataFixture Magento/SalesRule/_files/coupon_code_with_wildcard.php
      */
     public function testApplyCouponToCartWithNoItems()
     {
-        $couponCode = 'CART_FIXED_DISCOUNT_15';
+        $couponCode = '2?ds5!2d';
 
         $this->quoteResource->load($this->quote, 'test_order_1', 'reserved_order_id');
         $maskedQuoteId = $this->quoteIdToMaskedId->execute((int)$this->quote->getId());
@@ -104,12 +104,12 @@ public function testApplyCouponToCartWithNoItems()
 
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_simple_product_saved.php
-     * @magentoApiDataFixture Magento/SalesRule/_files/coupon_cart_fixed_discount.php
+     * @magentoApiDataFixture Magento/SalesRule/_files/coupon_code_with_wildcard.php
      * @magentoApiDataFixture Magento/Customer/_files/customer.php
      */
     public function testGuestCustomerAttemptToChangeCustomerCart()
     {
-        $couponCode = 'CART_FIXED_DISCOUNT_15';
+        $couponCode = '2?ds5!2d';
 
         $this->quoteResource->load(
             $this->quote,
@@ -127,11 +127,11 @@ public function testGuestCustomerAttemptToChangeCustomerCart()
 
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_simple_product_saved.php
-     * @magentoApiDataFixture Magento/SalesRule/_files/coupon_cart_fixed_discount.php
+     * @magentoApiDataFixture Magento/SalesRule/_files/coupon_code_with_wildcard.php
      */
     public function testRemoveCoupon()
     {
-        $couponCode = 'CART_FIXED_DISCOUNT_15';
+        $couponCode = '2?ds5!2d';
 
         /* Apply coupon to the quote */
         $this->quoteResource->load(
@@ -158,7 +158,7 @@ public function testRemoveCoupon()
 
     /**
      * @magentoApiDataFixture Magento/Checkout/_files/quote_with_simple_product_saved.php
-     * @magentoApiDataFixture Magento/SalesRule/_files/coupon_cart_fixed_discount.php
+     * @magentoApiDataFixture Magento/SalesRule/_files/coupon_code_with_wildcard.php
      * @magentoApiDataFixture Magento/Customer/_files/customer.php
      */
     public function testRemoveCouponFromCustomerCartByGuest()

dev/tests/integration/testsuite/Magento/SalesRule/_files/coupon_cart_fixed_discount.php

@@ -47,9 +47,3 @@
     ->setCode('CART_FIXED_DISCOUNT_15')
     ->setType(0);
 $objectManager->get(CouponRepositoryInterface::class)->save($coupon);
-
-/** @var Magento\Framework\Registry $registry */
-$registry = $objectManager->get(\Magento\Framework\Registry::class);
-
-$registry->unregister('cart_rule_fixed_discount_coupon');
-$registry->register('cart_rule_fixed_discount_coupon', $salesRule);

dev/tests/integration/testsuite/Magento/SalesRule/_files/coupon_code_with_wildcard_rollback.php

@@ -14,8 +14,19 @@
 
 $objectManager = Bootstrap::getObjectManager();
 
+/** @var SearchCriteriaBuilder $searchCriteriaBuilder */
+$searchCriteriaBuilder = Bootstrap::getObjectManager()->get(SearchCriteriaBuilder::class);
+$searchCriteria = $searchCriteriaBuilder->addFilter('name', '5$ fixed discount on whole cart')
+    ->create();
+
+/** @var RuleRepositoryInterface $ruleRepository */
+$ruleRepository = Bootstrap::getObjectManager()->get(RuleRepositoryInterface::class);
+$items = $ruleRepository->getList($searchCriteria)
+    ->getItems();
+
+$salesRule = array_pop($items);
+
 /** @var Rule $salesRule */
-$salesRule = getSalesRule('5$ fixed discount on whole cart');
 if ($salesRule !== null) {
     /** @var RuleRepositoryInterface $ruleRepository */
     $ruleRepository = $objectManager->get(RuleRepositoryInterface::class);
@@ -29,18 +40,3 @@
     $couponRepository = $objectManager->get(CouponRepositoryInterface::class);
     $couponRepository->deleteById($coupon->getCouponId());
 }
-
-function getSalesRule(string $name)
-{
-    /** @var SearchCriteriaBuilder $searchCriteriaBuilder */
-    $searchCriteriaBuilder = Bootstrap::getObjectManager()->get(SearchCriteriaBuilder::class);
-    $searchCriteria = $searchCriteriaBuilder->addFilter('name', $name)
-        ->create();
-
-    /** @var RuleRepositoryInterface $ruleRepository */
-    $ruleRepository = Bootstrap::getObjectManager()->get(RuleRepositoryInterface::class);
-    $items = $ruleRepository->getList($searchCriteria)
-        ->getItems();
-
-    return array_pop($items);
-}