REPO-70: [EQP][Sniffs Consolidation] Assign severity to each sniff

- review fixes

Author: lenaorobei

Magento/Sniffs/Security/IncludeFileSniff.php

@@ -93,7 +93,7 @@ public function process(File $phpcsFile, $stackPtr)
         if ($hasVariable) {
             $message .= ' Variables inside are insecure.';
         }
-        $phpcsFile->addWarning(
+        $phpcsFile->addError(
             $message,
             $stackPtr,
             $this->warningCode,

Magento/Tests/Security/IncludeFileUnitTest.php

@@ -3,6 +3,7 @@
  * Copyright © Magento. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\Tests\Security;
 
 use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
@@ -16,14 +17,6 @@ class IncludeFileUnitTest extends AbstractSniffUnitTest
      * @inheritdoc
      */
     public function getErrorList()
-    {
-        return [];
-    }
-
-    /**
-     * @inheritdoc
-     */
-    public function getWarningList()
     {
         return [
             3 => 1,
@@ -42,4 +35,12 @@ public function getWarningList()
             34 => 1,
         ];
     }
+
+    /**
+     * @inheritdoc
+     */
+    public function getWarningList()
+    {
+        return [];
+    }
 }

Magento/ruleset.xml

@@ -47,6 +47,10 @@
         <severity>10</severity>
         <type>error</type>
     </rule>
+    <rule ref="Magento.Security.IncludeFile">
+        <severity>10</severity>
+        <type>error</type>
+    </rule>
     <rule ref="Magento.Security.LanguageConstruct">
         <severity>10</severity>
         <type>error</type>
@@ -73,8 +77,16 @@
         <type>error</type>
     </rule>
 
-    <!-- Severity 9 warnings: Possible security issues. -->
-    <rule ref="Magento.Security.IncludeFile">
+    <!-- Severity 9 warnings: Possible security and issues that may cause bugs. -->
+    <rule ref="Generic.Files.ByteOrderMark">
+        <severity>9</severity>
+        <type>warning</type>
+    </rule>
+    <rule ref="Magento.PHP.DateTime">
+        <severity>9</severity>
+        <type>warning</type>
+    </rule>
+    <rule ref="Magento.PHP.DiscouragedFunction">
         <severity>9</severity>
         <type>warning</type>
     </rule>
@@ -87,6 +99,10 @@
         <severity>9</severity>
         <type>warning</type>
     </rule>
+    <rule ref="Squiz.PHP.NonExecutableCode">
+        <severity>9</severity>
+        <type>warning</type>
+    </rule>
 
     <!-- Severity 8 warnings: Magento specific code issues. -->
     <rule ref="Magento.Classes.ObjectInstantiation">
@@ -113,10 +129,6 @@
         <severity>8</severity>
         <type>warning</type>
     </rule>
-    <rule ref="Magento.PHP.DateTime">
-        <severity>8</severity>
-        <type>warning</type>
-    </rule>
     <rule ref="Magento.PHP.ShortEchoSyntax">
         <severity>8</severity>
         <type>warning</type>
@@ -183,10 +195,6 @@
         <severity>7</severity>
         <type>warning</type>
     </rule>
-    <rule ref="Magento.PHP.DiscouragedFunction">
-        <severity>7</severity>
-        <type>warning</type>
-    </rule>
     <rule ref="Magento.PHP.LiteralNamespaces">
         <severity>7</severity>
         <type>warning</type>
@@ -219,10 +227,6 @@
         <severity>7</severity>
         <type>warning</type>
     </rule>
-    <rule ref="Squiz.PHP.NonExecutableCode">
-        <severity>7</severity>
-        <type>warning</type>
-    </rule>
     <rule ref="Squiz.Scope.MemberVarScope">
         <severity>7</severity>
         <type>warning</type>
@@ -233,10 +237,6 @@
         <severity>6</severity>
         <type>warning</type>
     </rule>
-    <rule ref="Generic.Files.ByteOrderMark">
-        <severity>6</severity>
-        <type>warning</type>
-    </rule>
     <rule ref="Generic.Files.LineEndings">
         <severity>6</severity>
         <type>warning</type>