Skip to content

Commit d47a669

Browse files
committed
AC-669: Create phpcs static check for InstallUpgradeTest
1 parent 230facd commit d47a669

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

Magento2/Tests/Eslint/AbstractEslintTestCase.php

+1-2
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ protected function assertFileContainsError(string $testFile, array $expectedMess
2424
{
2525
exec(
2626
'npm run eslint -- Magento2/Tests/Eslint/' . $testFile,
27-
$output,
28-
$exitCode
27+
$output
2928
);
3029

3130
foreach ($expectedMessages as $message) {

Magento2/Tests/Legacy/InstallUpgradeUnitTest.php

+6
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,13 @@ protected function getTestFiles($testFileBase): array
3636
$dir = __DIR__.'/_files/InstallUpgradeUnitTest';
3737
$di = new RecursiveIteratorIterator(new RecursiveDirectoryIterator($dir));
3838

39+
/**
40+
* @var DirectoryIterator $file
41+
*/
3942
foreach ($di as $file) {
43+
if ($file->isDir()) {
44+
continue;
45+
}
4046
$path = $file->getPathname();
4147
if ($path !== $testFileBase.'php' && substr($path, -5) !== 'fixed' && substr($path, -4) !== '.bak') {
4248
$testFiles[] = $path;

0 commit comments

Comments
 (0)