#20: add parrent

Author: Lars Roettig

Magento2/Sniffs/Performance/ForeachArrayMergeSniff.php

@@ -16,7 +16,7 @@ class ForeachArrayMergeSniff implements Sniff
      *
      * @var string
      */
-    protected $warningMessage = 'Array merge is slow in each functions. ';
+    protected $warningMessage = 'array_merge(...) is used in a loop and is a resources greedy construction.';
 
     /**
      * Warning violation code.
@@ -25,6 +25,11 @@ class ForeachArrayMergeSniff implements Sniff
      */
     protected $warningCode = 'ForeachArrayMerge';
 
+    /**
+     * @var array
+     */
+    protected $foreachCache = [];
+
     /**
      * @inheritdoc
      */
@@ -41,10 +46,9 @@ public function process(File $phpcsFile, $stackPtr)
         $tokens = $phpcsFile->getTokens();
 
         $scopeOpener = $tokens[$stackPtr]['scope_opener'];
-        $scopeCloser = $tokens[$stackPtr]['scope_closer'] ;
+        $scopeCloser = $tokens[$stackPtr]['scope_closer'];
 
-        for ($i = $scopeOpener; $i <  $scopeCloser; $i++)
-        {
+        for ($i = $scopeOpener; $i < $scopeCloser; $i++) {
             $tag = $tokens[$i];
             if ($tag['code'] !== T_STRING) {
                 continue;
@@ -53,6 +57,11 @@ public function process(File $phpcsFile, $stackPtr)
                 continue;
             }
 
+            $cacheKey = $phpcsFile->getFilename() . $i;
+            if (isset($this->foreachCache[$cacheKey])) {
+                continue;
+            }
+
             $phpcsFile->addWarning($this->warningMessage, $i, $this->warningCode);
         }
     }

Magento2/Tests/Performance/ForeachArrayMergeUnitTest.inc

@@ -5,8 +5,11 @@ $configurationSources = [
 ];
 
 $options = [];
-foreach ($configurationSources as $source) {
-    $options = array_merge($options, $source);
+
+foreach ([] as $collection) {
+    foreach ($configurationSources as $source) {
+        $options = array_merge($options, $source);
+    }
 }
 
 $options = [];
@@ -15,3 +18,17 @@ for ($i = 0; $i <= $itemCount; $i++) {
     $source = $options[$itemCount];
     $options = array_merge($options, $source));
 }
+
+class CSV
+{
+    public static function getColumns()
+    {
+        return [];
+    }
+}
+
+foreach ([] as $collection) {
+    foreach ($configurationSources as $source) {
+        $options = array_merge(CSV::getColumns(), $source);
+    }
+}

Magento2/Tests/Performance/ForeachArrayMergeUnitTest.php

@@ -26,8 +26,8 @@ public function getErrorList()
     public function getWarningList()
     {
         return [
-            9 => 1,
-            16 => 1,
+            11 => 1,
+            19 => 1,
         ];
     }
 }