diff --git a/Magento2/Sniffs/Security/InsecureFunctionSniff.php b/Magento2/Sniffs/Security/InsecureFunctionSniff.php index ddc80f7e..68b09382 100644 --- a/Magento2/Sniffs/Security/InsecureFunctionSniff.php +++ b/Magento2/Sniffs/Security/InsecureFunctionSniff.php @@ -33,9 +33,11 @@ class InsecureFunctionSniff extends ForbiddenFunctionsSniff 'pcntl_exec' => null, 'popen' => null, 'proc_open' => null, - 'serialize' => 'json_encode', + 'serialize' => '\Magento\Framework\Serialize\SerializerInterface::serialize', 'shell_exec' => null, 'system' => null, - 'unserialize' => 'json_decode', + 'unserialize' => '\Magento\Framework\Serialize\SerializerInterface::unserialize', + 'srand' => null, + 'mt_srand'=> null, ]; } diff --git a/Magento2/Tests/Security/InsecureFunctionUnitTest.inc b/Magento2/Tests/Security/InsecureFunctionUnitTest.inc index 6f62c45d..a502580a 100644 --- a/Magento2/Tests/Security/InsecureFunctionUnitTest.inc +++ b/Magento2/Tests/Security/InsecureFunctionUnitTest.inc @@ -23,3 +23,7 @@ proc_open('echo 1;'); create_function('args', 'code'); pcntl_exec('path/goes/here'); + +srand(); + +mt_srand(); diff --git a/Magento2/Tests/Security/InsecureFunctionUnitTest.php b/Magento2/Tests/Security/InsecureFunctionUnitTest.php index 33054944..5a35a8d2 100644 --- a/Magento2/Tests/Security/InsecureFunctionUnitTest.php +++ b/Magento2/Tests/Security/InsecureFunctionUnitTest.php @@ -38,6 +38,8 @@ public function getWarningList() 21 => 1, 23 => 1, 25 => 1, + 27 => 1, + 29 => 1, ]; } }