Skip to content

Commit 094d555

Browse files
neillrobsondimonovp
authored andcommitted
Fix faulty admin spinner animation
When the @spinner-delay variable does not have a unit (s/seconds), the generated animation-delay attribute for the western spinner spoke also lacks a unit. In certain browsers (I am testing with Firefox Developer Edition 59.0b10 (64-bit)), this CSS style is marked as invalid and not applied, causing the western and south-western spokes of the spinner to flash out of order in the resulting animation. I assume that, somewhere in the LESS calculations, the @spinner-delay and @spinner-animation-step variables are combined with arithmetic, coercing the resulting spoke style to have the correct units: this coercion does not occur for the final spoke, perhaps because the arithmetic involved does not include the last child (for which the animation delay should be at a maximum). In any case, the error is hardly noticeable, but there's no reason to let such a easily-fixable styling omission slip through the cracks.
1 parent dea8b32 commit 094d555

File tree

1 file changed

+1
-1
lines changed
  • app/design/adminhtml/Magento/backend/web/css/source/variables

1 file changed

+1
-1
lines changed

app/design/adminhtml/Magento/backend/web/css/source/variables/_spinner.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,4 @@
2626
@spinner-rotate-step: 45;
2727

2828
// One step in degree
29-
@spinner-delay: .9;
29+
@spinner-delay: .9s;

0 commit comments

Comments
 (0)