Polish up implementation

orlangur · gelanivishal · commit 11a95d641009 · 2018-07-04T02:00:15.000Z
diff --git a/lib/internal/Magento/Framework/Data/Form/FormKey/Validator.php b/lib/internal/Magento/Framework/Data/Form/FormKey/Validator.php
@@ -34,11 +34,7 @@ public function __construct(\Magento\Framework\Data\Form\FormKey $formKey)
     public function validate(\Magento\Framework\App\RequestInterface $request)
     {
         $formKey = $request->getParam('form_key', null);
-
-        if (!$formKey) {
-            return false;
-        }
-
-        return Security::compareStrings($formKey, $this->_formKey->getFormKey());
+        
+        return $formKey && Security::compareStrings($formKey, $this->_formKey->getFormKey());
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -34,11 +34,7 @@ public function __construct(\Magento\Framework\Data\Form\FormKey $formKey)`
`34`	`34`	`public function validate(\Magento\Framework\App\RequestInterface $request)`
`35`	`35`	`{`
`36`	`36`	`$formKey = $request->getParam('form_key', null);`
`37`		`-`
`38`		`- if (!$formKey) {`
`39`		`- return false;`
`40`		`- }`
`41`		`-`
`42`		`- return Security::compareStrings($formKey, $this->_formKey->getFormKey());`
	`37`	`+`
	`38`	`+ return $formKey && Security::compareStrings($formKey, $this->_formKey->getFormKey());`
`43`	`39`	`}`
`44`	`40`	`}`