MC-36456: union implementation

cpartica · cpartica · commit 13a580692624 · 2020-08-28T17:08:15.000-05:00
diff --git a/lib/internal/Magento/Framework/GraphQlSchemaStitching/GraphQlReader.php b/lib/internal/Magento/Framework/GraphQlSchemaStitching/GraphQlReader.php
@@ -332,9 +332,9 @@ private function addModuleNameToTypes(array $source, string $filePath): array
     {
         foreach ($source as $typeName => $typeDefinition) {
             if (!isset($typeDefinition['module'])) {
-                $hasTypeResolver = (bool)$typeDefinition['typeResolver'] ?? false;
-                $hasImplements = (bool)$typeDefinition['implements'] ?? false;
-                $typeDefinition = (bool)$typeDefinition['type'] ?? false;
+                $hasTypeResolver = (bool)($typeDefinition['typeResolver'] ?? false);
+                $hasImplements = (bool)($typeDefinition['implements'] ?? false);
+                $typeDefinition = (bool)($typeDefinition['type'] ?? false);
                 if ((($typeDefinition === InterfaceType::GRAPHQL_INTERFACE && $hasTypeResolver) || $hasImplements)) {
                     $source[$typeName]['module'] = self::getModuleNameForRelevantFile($filePath);
                 }

Original file line number	Diff line number	Diff line change
`@@ -332,9 +332,9 @@ private function addModuleNameToTypes(array $source, string $filePath): array`
`332`	`332`	`{`
`333`	`333`	`foreach ($source as $typeName => $typeDefinition) {`
`334`	`334`	`if (!isset($typeDefinition['module'])) {`
`335`		`- $hasTypeResolver = (bool)$typeDefinition['typeResolver'] ?? false;`
`336`		`- $hasImplements = (bool)$typeDefinition['implements'] ?? false;`
`337`		`- $typeDefinition = (bool)$typeDefinition['type'] ?? false;`
	`335`	`+ $hasTypeResolver = (bool)($typeDefinition['typeResolver'] ?? false);`
	`336`	`+ $hasImplements = (bool)($typeDefinition['implements'] ?? false);`
	`337`	`+ $typeDefinition = (bool)($typeDefinition['type'] ?? false);`
`338`	`338`	`if ((($typeDefinition === InterfaceType::GRAPHQL_INTERFACE && $hasTypeResolver) \|\| $hasImplements)) {`
`339`	`339`	`$source[$typeName]['module'] = self::getModuleNameForRelevantFile($filePath);`
`340`	`340`	`}`