Merge remote-tracking branch 'perf-ce/ACPT-815' into ACPT-809

aa-kashk · aa-kashk · commit 183567927393 · 2022-11-09T11:20:07.000-06:00
diff --git a/app/code/Magento/Elasticsearch/Model/Adapter/BatchDataMapper/ProductDataMapper.php b/app/code/Magento/Elasticsearch/Model/Adapter/BatchDataMapper/ProductDataMapper.php
@@ -370,8 +370,11 @@ private function getValuesLabels(Attribute $attribute, array $attributeValues, i
             return $attributeLabels;
         }
 
+        // array_flip() + foreach { isset() }  is much faster than foreach { in_array() } when there are many options
+        $attributeValues = array_flip($attributeValues);
+
         foreach ($options as $option) {
-            if (\in_array($option['value'], $attributeValues)) {
+            if (isset($attributeValues[$option['value']])) {
                 $attributeLabels[] = $option['label'];
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -370,8 +370,11 @@ private function getValuesLabels(Attribute $attribute, array $attributeValues, i`
`370`	`370`	`return $attributeLabels;`
`371`	`371`	`}`
`372`	`372`
	`373`	`+ // array_flip() + foreach { isset() } is much faster than foreach { in_array() } when there are many options`
	`374`	`+ $attributeValues = array_flip($attributeValues);`
	`375`	`+`
`373`	`376`	`foreach ($options as $option) {`
`374`		`- if (\in_array($option['value'], $attributeValues)) {`
	`377`	`+ if (isset($attributeValues[$option['value']])) {`
`375`	`378`	`$attributeLabels[] = $option['label'];`
`376`	`379`	`}`
`377`	`380`	`}`