ENGCOM-2935: [Forwardport] Move functions.php into Framework #17960

Author: Stanislav Idolov

app/bootstrap.php

@@ -31,8 +31,6 @@
 // Sets default autoload mappings, may be overridden in Bootstrap::create
 \Magento\Framework\App\Bootstrap::populateAutoloader(BP, []);
 
-require_once BP . '/app/functions.php';
-
 /* Custom umask value may be provided in optional mage_umask file in root */
 $umaskFile = BP . '/magento_umask';
 $mask = file_exists($umaskFile) ? octdec(file_get_contents($umaskFile)) : 002;

app/functions.php

@@ -6,17 +6,22 @@
 
 /**
  * Create value-object \Magento\Framework\Phrase
- *
+ * @deprecated The global function __() is now loaded via Magento Framework, the below require is only
+ *             for backwards compatibility reasons and this file will be removed in a future version
+ * @see        Magento\Framework\Phrase\__.php
+ * @SuppressWarnings(PHPMD.ShortMethodName)
  * @return \Magento\Framework\Phrase
  */
-function __()
-{
-    $argc = func_get_args();
+if (!function_exists('__')) {
+    function __()
+    {
+        $argc = func_get_args();
 
-    $text = array_shift($argc);
-    if (!empty($argc) && is_array($argc[0])) {
-        $argc = $argc[0];
-    }
+        $text = array_shift($argc);
+        if (!empty($argc) && is_array($argc[0])) {
+            $argc = $argc[0];
+        }
 
-    return new \Magento\Framework\Phrase($text, $argc);
+        return new \Magento\Framework\Phrase($text, $argc);
+    }
 }

dev/tests/unit/framework/bootstrap.php

@@ -11,7 +11,6 @@
 }
 
 require_once __DIR__ . '/autoload.php';
-require BP . '/app/functions.php';
 
 setCustomErrorHandler();
 

lib/internal/Magento/Framework/Phrase/__.php

@@ -0,0 +1,23 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+/**
+ * Create value-object \Magento\Framework\Phrase
+ * @SuppressWarnings(PHPMD.ShortMethodName)
+ * @return \Magento\Framework\Phrase
+ */
+function __()
+{
+    $argc = func_get_args();
+
+    $text = array_shift($argc);
+    if (!empty($argc) && is_array($argc[0])) {
+        $argc = $argc[0];
+    }
+
+    return new \Magento\Framework\Phrase($text, $argc);
+}

lib/internal/Magento/Framework/registration.php

@@ -7,3 +7,7 @@
 use \Magento\Framework\Component\ComponentRegistrar;
 
 ComponentRegistrar::register(ComponentRegistrar::LIBRARY, 'magento/framework', __DIR__);
+
+if (!function_exists('__')) {
+    require 'Phrase/__.php';
+}