Merge pull request #5963 from magento-tsg/MC-36343

zakdma · web-flow · commit 237c2b18a88f · 2020-08-09T11:45:52.000+03:00
[TSG] MC-36343: Unnecessary quotes causes invalid HTML in tracking.phtml
diff --git a/app/code/Magento/AdminAnalytics/view/adminhtml/templates/tracking.phtml b/app/code/Magento/AdminAnalytics/view/adminhtml/templates/tracking.phtml
@@ -12,7 +12,7 @@
 <?= /* @noEscape */ $secureRenderer->renderTag(
     'script',
     [
-        'src' => '"' . $block->escapeJs($block->getTrackingUrl()) .'"',
+        'src' => $block->getTrackingUrl(),
         'async' => true,
     ],
     '&nbsp;',

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`<?= /* @noEscape */ $secureRenderer->renderTag(`
`13`	`13`	`'script',`
`14`	`14`	`[`
`15`		`- 'src' => '"' . $block->escapeJs($block->getTrackingUrl()) .'"',`
	`15`	`+ 'src' => $block->getTrackingUrl(),`
`16`	`16`	`'async' => true,`
`17`	`17`	`],`
`18`	`18`	`' ',`