Skip to content

Commit 2539a71

Browse files
committed
catalog:images:resize fails to process all images -> Possible underlying Magento/Framework/DB/Query/Generator issue - remove method return type 'void' which can be used in php7.1 or higher.
1 parent d2e5345 commit 2539a71

File tree

1 file changed

+3
-3
lines changed
  • app/code/Magento/Catalog/Test/Unit/Model/ResourceModel/Product

1 file changed

+3
-3
lines changed

app/code/Magento/Catalog/Test/Unit/Model/ResourceModel/Product/ImageTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class ImageTest extends \PHPUnit\Framework\TestCase
3636
*/
3737
protected $resourceMock;
3838

39-
protected function setUp(): void
39+
protected function setUp()
4040
{
4141
$this->objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
4242
$this->connectionMock = $this->createMock(AdapterInterface::class);
@@ -75,7 +75,7 @@ protected function getVisibleImagesSelectMock(): \PHPUnit_Framework_MockObject_M
7575
* @param int $imagesCount
7676
* @dataProvider dataProvider
7777
*/
78-
public function testGetCountAllProductImages(int $imagesCount): void
78+
public function testGetCountAllProductImages(int $imagesCount)
7979
{
8080
$selectMock = $this->getVisibleImagesSelectMock();
8181
$selectMock->expects($this->exactly(2))
@@ -113,7 +113,7 @@ public function testGetCountAllProductImages(int $imagesCount): void
113113
* @param int $batchSize
114114
* @dataProvider dataProvider
115115
*/
116-
public function testGetAllProductImages(int $imagesCount, int $batchSize): void
116+
public function testGetAllProductImages(int $imagesCount, int $batchSize)
117117
{
118118
$this->connectionMock->expects($this->once())
119119
->method('select')

0 commit comments

Comments
 (0)