MAGETWO-43236: [GITHUB] use return value instead of reference parameter #1818

Maxim Medinskiy · Maxim Medinskiy · commit 260306a3c147 · 2015-09-25T14:36:14.000+03:00
diff --git a/app/code/Magento/Sales/Test/Unit/Ui/Component/Listing/Column/ViewActionTest.php b/app/code/Magento/Sales/Test/Unit/Ui/Component/Listing/Column/ViewActionTest.php
@@ -68,7 +68,7 @@ public function testPrepareDataSource(
                 'items' => $dataSourceItems
             ]
         ];
-        $this->model->prepareDataSource($dataSource);
+        $dataSource = $this->model->prepareDataSource($dataSource);
         $this->assertEquals($expectedDataSourceItems, $dataSource['data']['items']);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ public function testPrepareDataSource(`
`68`	`68`	`'items' => $dataSourceItems`
`69`	`69`	`]`
`70`	`70`	`];`
`71`		`- $this->model->prepareDataSource($dataSource);`
	`71`	`+ $dataSource = $this->model->prepareDataSource($dataSource);`
`72`	`72`	`$this->assertEquals($expectedDataSourceItems, $dataSource['data']['items']);`
`73`	`73`	`}`
`74`	`74`