Skip to content

Commit 29ccdae

Browse files
authored
Remove unnecesary "header" block redeclaration
Remove unnecesary header block redeclaration on Magento Luma Theme, which made impossible to set the header template through custom modules. Example: - Create new module. - Create new default.xml and try to use referenceBlock to set the template. - Doesn't work, because Luma theme XML files are compiled after all modules and overrides the custom module modifications. Removed because this block was already created in module Magento_Theme, so this redeclaration is just unnecesary
1 parent c515b40 commit 29ccdae

File tree

1 file changed

+0
-5
lines changed
  • app/design/frontend/Magento/luma/Magento_Customer/layout

1 file changed

+0
-5
lines changed

app/design/frontend/Magento/luma/Magento_Customer/layout/default.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@
1515
</arguments>
1616
</block>
1717
</referenceBlock>
18-
<block class="Magento\Theme\Block\Html\Header" name="header" as="header">
19-
<arguments>
20-
<argument name="show_part" xsi:type="string">welcome</argument>
21-
</arguments>
22-
</block>
2318
<move element="header" destination="header.links" before="-"/>
2419
<move element="register-link" destination="header.links"/>
2520
<move element="top.links" destination="customer"/>

0 commit comments

Comments
 (0)