[TASK] Updated according to Codacy/PR Quality Review

lewisvoncken · lewisvoncken · commit 2d6fb6253dff · 2018-05-06T19:50:54.000+02:00
diff --git a/app/code/Magento/Catalog/Model/Indexer/Product/Flat/Action/Row.php b/app/code/Magento/Catalog/Model/Indexer/Product/Flat/Action/Row.php
@@ -61,6 +61,7 @@ public function __construct(
      * @param int|null $id
      * @return \Magento\Catalog\Model\Indexer\Product\Flat\Action\Row
      * @throws \Magento\Framework\Exception\LocalizedException
+     * @throws \Zend_Db_Statement_Exception
      */
     public function execute($id = null)
     {
@@ -109,11 +110,10 @@ public function execute($id = null)
                     }
                     $this->flatItemWriter->write($store->getId(), $ids[0], $this->_valueFieldSuffix);
                 }
-            } else {
+            }
+            if ($status['value'] == \Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS_DISABLED) {
                 $this->flatItemEraser->deleteProductsFromStore($id, $store->getId());
             }
-
-
         }
         return $this;
     }

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,7 @@ public function __construct(`
`61`	`61`	`* @param int\|null $id`
`62`	`62`	`* @return \Magento\Catalog\Model\Indexer\Product\Flat\Action\Row`
`63`	`63`	`* @throws \Magento\Framework\Exception\LocalizedException`
	`64`	`+ * @throws \Zend_Db_Statement_Exception`
`64`	`65`	`*/`
`65`	`66`	`public function execute($id = null)`
`66`	`67`	`{`
`@@ -109,11 +110,10 @@ public function execute($id = null)`
`109`	`110`	`}`
`110`	`111`	`$this->flatItemWriter->write($store->getId(), $ids[0], $this->_valueFieldSuffix);`
`111`	`112`	`}`
`112`		`- } else {`
	`113`	`+ }`
	`114`	`+ if ($status['value'] == \Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS_DISABLED) {`
`113`	`115`	`$this->flatItemEraser->deleteProductsFromStore($id, $store->getId());`
`114`	`116`	`}`
`115`		`-`
`116`		`-`
`117`	`117`	`}`
`118`	`118`	`return $this;`
`119`	`119`	`}`