ENGCOM-2570: [Backport] FIXED: FTP user and password strings urldecoded #17246

magento-engcom-team · magento-engcom-team · commit 34ffac7613f3 · 2018-07-28T15:01:46.000-05:00
- Merge Pull Request #17246 from mage2pratik/magento2:2.2-develop-PR-port-16876 - Merged commits: 1. 7866d00 2. a1ebbee
diff --git a/lib/internal/Magento/Framework/System/Ftp.php b/lib/internal/Magento/Framework/System/Ftp.php
@@ -105,6 +105,12 @@ public function validateConnectionString($string)
         if ($data['scheme'] != 'ftp') {
             throw new \Exception("Support for scheme unsupported: '{$data['scheme']}'");
         }
+        
+        // Decode user & password strings from URL
+        foreach (array_intersect(array_keys($data), ['user','pass']) as $key) {
+            $data[$key] = urldecode($data[$key]);
+        }
+        
         return $data;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,12 @@ public function validateConnectionString($string)`
`105`	`105`	`if ($data['scheme'] != 'ftp') {`
`106`	`106`	`throw new \Exception("Support for scheme unsupported: '{$data['scheme']}'");`
`107`	`107`	`}`
	`108`	`+`
	`109`	`+ // Decode user & password strings from URL`
	`110`	`+ foreach (array_intersect(array_keys($data), ['user','pass']) as $key) {`
	`111`	`+ $data[$key] = urldecode($data[$key]);`
	`112`	`+ }`
	`113`	`+`
`108`	`114`	`return $data;`
`109`	`115`	`}`
`110`	`116`