Skip to content

Commit 35e79d5

Browse files
author
Stanislav Idolov
authored
ENGCOM-1648: Resolve Knockout non-unique elements id in console error #15349
2 parents 98cd71b + d78fd0c commit 35e79d5

File tree

2 files changed

+4
-2
lines changed
  • app/code/Magento/Checkout/view/frontend/web/template/billing-address
  • dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Checkout/Section

2 files changed

+4
-2
lines changed

app/code/Magento/Checkout/view/frontend/web/template/billing-address/form.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@
99
<!-- ko template: getTemplate() --><!-- /ko -->
1010
<!--/ko-->
1111
<form data-bind="attr: {'data-hasrequired': $t('* Required Fields')}">
12-
<fieldset id="billing-new-address-form" class="fieldset address">
12+
<fieldset
13+
data-bind="attr: { id:'billing-new-address-form-'+index, value:index}"
14+
class="billing-new-address-form fieldset address">
1315
<!-- ko foreach: getRegion('additional-fieldsets') -->
1416
<!-- ko template: getTemplate() --><!-- /ko -->
1517
<!--/ko-->

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Checkout/Section/CheckoutPaymentSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<element name="isPaymentSection" type="text" selector="//*[@class='opc-progress-bar']/li[contains(@class, '_active') and span[contains(.,'Review &amp; Payments')]]"/>
1313
<element name="availablePaymentSolutions" type="text" selector="#checkout-payment-method-load>div>div>div:nth-child(2)>div.payment-method-title.field.choice"/>
1414
<element name="notAvailablePaymentSolutions" type="text" selector="#checkout-payment-method-load>div>div>div.payment-method._active>div.payment-method-title.field.choice"/>
15-
<element name="billingNewAddressForm" type="text" selector="#billing-new-address-form"/>
15+
<element name="billingNewAddressForm" type="text" selector=".billing-new-address-form"/>
1616
<element name="placeOrderDisabled" type="button" selector="#checkout-payment-method-load button.disabled"/>
1717
<element name="update" type="button" selector=".payment-method-billing-address .action.action-update"/>
1818
<element name="guestFirstName" type="input" selector=".billing-address-form input[name*='firstname']"/>

0 commit comments

Comments
 (0)