Skip to content

Commit 38bfe66

Browse files
committed
Fix the issue with missing asterisk for admin required fields #18904
1 parent 4421098 commit 38bfe66

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

app/code/Magento/Ui/view/base/web/templates/form/field.html

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@
88
visible="visible"
99
css="$data.additionalClasses"
1010
attr="'data-index': index">
11-
<span class="admin__field-label" if="$data.label" visible="$data.labelVisible">
12-
<label translate="label" attr="'data-config-scope': $data.scopeLabel, for: uid"/>
13-
</span>
11+
<div class="admin__field-label" visible="$data.labelVisible">
12+
<label if="$data.label" attr="for: uid">
13+
<span translate="label" attr="'data-config-scope': $data.scopeLabel" />
14+
</label>
15+
</div>
1416
<div class="admin__field-control"
1517
css="'_with-tooltip': $data.tooltip, '_with-reset': $data.showFallbackReset && $data.isDifferedFromDefault">
1618
<render args="elementTmpl" ifnot="hasAddons()"/>

app/design/adminhtml/Magento/backend/web/css/source/forms/_extends.less

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@
5454
&._required {
5555
> .admin__field-label {
5656
span {
57+
padding-left: 1.5rem;
58+
5759
&:after {
5860
left: 0;
5961
margin-left: @temp_gutter;

app/design/adminhtml/Magento/backend/web/css/source/forms/_fields.less

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@
221221
overflow: hidden;
222222
}
223223

224-
label {
224+
span {
225225
display: inline-block;
226226
line-height: @field-label__line-height;
227227
vertical-align: middle;
@@ -239,7 +239,7 @@
239239

240240
.required > &, // ToDo UI: change classes 'required' to '_required'.
241241
._required > & {
242-
> label {
242+
span {
243243
&:after {
244244
color: @validation__color;
245245
content: '*';

0 commit comments

Comments
 (0)