fixed notice when remove column from grid

magekey · magekey · commit 39be46643bb5 · 2017-08-18T05:52:56.000+03:00
diff --git a/app/code/Magento/Backend/Block/Widget/Grid/Extended.php b/app/code/Magento/Backend/Block/Widget/Grid/Extended.php
@@ -314,7 +314,8 @@ public function removeColumn($columnId)
         if ($this->getColumnSet()->getChildBlock($columnId)) {
             $this->getColumnSet()->unsetChild($columnId);
             if ($this->_lastColumnId == $columnId) {
-                $this->_lastColumnId = array_pop($this->getColumnSet()->getChildNames());
+                $names = $this->getColumnSet()->getChildNames();
+                $this->_lastColumnId = array_pop($names);
             }
         }
         return $this;

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,8 @@ public function removeColumn($columnId)`
`314`	`314`	`if ($this->getColumnSet()->getChildBlock($columnId)) {`
`315`	`315`	`$this->getColumnSet()->unsetChild($columnId);`
`316`	`316`	`if ($this->_lastColumnId == $columnId) {`
`317`		`- $this->_lastColumnId = array_pop($this->getColumnSet()->getChildNames());`
	`317`	`+ $names = $this->getColumnSet()->getChildNames();`
	`318`	`+ $this->_lastColumnId = array_pop($names);`
`318`	`319`	`}`
`319`	`320`	`}`
`320`	`321`	`return $this;`