Backport 2.2 - Don't set a source model on the attribute when it's not needed. This avoids accidentally persisting the source model to the database when using multiselect attributes.

hostep · hostep · commit 3e066db75e49 · 2018-10-04T20:37:12.000+02:00
(cherry picked from commit 477ca51)
diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php b/app/code/Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php
@@ -594,9 +594,11 @@ public function getSource()
     {
         if (empty($this->_source)) {
             if (!$this->getSourceModel()) {
-                $this->setSourceModel($this->_getDefaultSourceModel());
+                $this->_source = $this->_getDefaultSourceModel();
+            } else {
+                $this->_source = $this->getSourceModel();
             }
-            $source = $this->_universalFactory->create($this->getSourceModel());
+            $source = $this->_universalFactory->create($this->_source);
             if (!$source) {
                 throw new LocalizedException(
                     __(

Original file line number	Diff line number	Diff line change
`@@ -594,9 +594,11 @@ public function getSource()`
`594`	`594`	`{`
`595`	`595`	`if (empty($this->_source)) {`
`596`	`596`	`if (!$this->getSourceModel()) {`
`597`		`- $this->setSourceModel($this->_getDefaultSourceModel());`
	`597`	`+ $this->_source = $this->_getDefaultSourceModel();`
	`598`	`+ } else {`
	`599`	`+ $this->_source = $this->getSourceModel();`
`598`	`600`	`}`
`599`		`- $source = $this->_universalFactory->create($this->getSourceModel());`
	`601`	`+ $source = $this->_universalFactory->create($this->_source);`
`600`	`602`	`if (!$source) {`
`601`	`603`	`throw new LocalizedException(`
`602`	`604`	`__(`