Skip to content

Commit 44502ff

Browse files
🔃 [EngCom] Public Pull Requests - 2.2-develop
Accepted Public Pull Requests: - #15256: Fixed typo in method name (by @olmer) - #15137: fix: do not forcefully set area in template if it is already set, fixes #14968, fixes #13530 (by @DanielRuf) Fixed GitHub Issues: - #13530: "Template file 'header.html' is not found" error while trying to save Design Configuration. (reported by @hostep) has been fixed in #15137 by @DanielRuf in 2.2-develop branch Related commits: 1. 0ae1230 2. 3df51d4 3. 0dec988 4. d92b679 - #14968: Can't change the applied theme in 2.2.4 (reported by @Krapulat) has been fixed in #15137 by @DanielRuf in 2.2-develop branch Related commits: 1. 0ae1230 2. 3df51d4 3. 0dec988 4. d92b679
2 parents 7c711dd + 7019a0a commit 44502ff

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

app/code/Magento/Email/Model/AbstractTemplate.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -534,10 +534,9 @@ protected function cancelDesignConfig()
534534
*/
535535
public function setForcedArea($templateId)
536536
{
537-
if ($this->area) {
538-
throw new \LogicException(__('Area is already set'));
537+
if (!isset($this->area)) {
538+
$this->area = $this->emailConfig->getTemplateArea($templateId);
539539
}
540-
$this->area = $this->emailConfig->getTemplateArea($templateId);
541540
return $this;
542541
}
543542

lib/internal/Magento/Framework/App/Request/Http.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ public function setPathInfo($pathInfo = null)
149149
return $this;
150150
}
151151

152-
$requestUri = $this->removeRepitedSlashes($requestUri);
152+
$requestUri = $this->removeRepeatedSlashes($requestUri);
153153
$parsedRequestUri = explode('?', $requestUri, 2);
154154
$queryString = !isset($parsedRequestUri[1]) ? '' : '?' . $parsedRequestUri[1];
155155
$baseUrl = $this->getBaseUrl();
@@ -172,7 +172,7 @@ public function setPathInfo($pathInfo = null)
172172
* @param string $pathInfo
173173
* @return string
174174
*/
175-
private function removeRepitedSlashes($pathInfo)
175+
private function removeRepeatedSlashes($pathInfo)
176176
{
177177
$firstChar = (string)substr($pathInfo, 0, 1);
178178
if ($firstChar == '/') {

0 commit comments

Comments
 (0)