MAGETWO-58132: [GitHub] module:uninstall can remove code it uses itself #5797

Author: shiftedreality

dev/tests/integration/testsuite/Magento/Framework/Composer/RemoveTest.php

@@ -5,31 +5,32 @@
  */
 namespace Magento\Framework\Composer;
 
-use Magento\Framework\App\Filesystem\DirectoryList;
+use Magento\Composer\MagentoComposerApplication;
 
 class RemoveTest extends \PHPUnit_Framework_TestCase
 {
     public function testRemove()
     {
-        $composerAppFactory = $this->getMock(
-            \Magento\Framework\Composer\MagentoComposerApplicationFactory::class,
-            [],
-            [],
-            '',
-            false
-        );
+        $composerAppFactory = $this->getMockBuilder(MagentoComposerApplicationFactory::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $composerApp = $this->getMockBuilder(MagentoComposerApplication::class)
+            ->disableOriginalConstructor()
+            ->getMock();
 
-        $composerApp = $this->getMock(
-            \Magento\Composer\MagentoComposerApplication::class,
-            [],
-            [],
-            '',
-            false
-        );
+        $composerApp->expects($this->once())
+            ->method('runComposerCommand')
+            ->with(
+                [
+                    'command' => 'remove',
+                    'packages' => ['magento/package-a', 'magento/package-b'],
+                    '--no-update' => true,
+                ]
 
-        $composerApp->expects($this->once())->method('runComposerCommand');
-
-        $composerAppFactory->expects($this->once())->method('create')->willReturn($composerApp);
+            );
+        $composerAppFactory->expects($this->once())
+            ->method('create')
+            ->willReturn($composerApp);
 
         $remove = new Remove($composerAppFactory);
         $remove->remove(['magento/package-a', 'magento/package-b']);

lib/internal/Magento/Framework/Composer/Remove.php

@@ -45,7 +45,8 @@ public function remove(array $packages)
         return $composerApplication->runComposerCommand(
             [
                 'command' => 'remove',
-                'packages' => $packages
+                'packages' => $packages,
+                '--no-update' => true,
             ]
         );
     }