tests_correct

Author: yurii-v-git

app/code/Magento/Catalog/Model/Product/Copier.php

@@ -117,13 +117,21 @@ private function setDefaultUrl(Product $product, Product $duplicate) : void
     private function setStoresUrl(Product $product, Product $duplicate) : void
     {
         $storeIds = $duplicate->getStoreIds();
-        $resource = $product->getResource();
         $productId = $product->getId();
+        $productResource = $product->getResource();
+        $defaultUrlKey = $productResource->getAttributeRawValue(
+                $productId,
+                'url_key',
+                \Magento\Store\Model\Store::DEFAULT_STORE_ID
+            );
         $duplicate->setData('save_rewrites_history', false);
         foreach ($storeIds as $storeId) {
             $isDuplicateSaved = false;
             $duplicate->setStoreId($storeId);
-            $urlKey = $resource->getAttributeRawValue($productId, 'url_key', $storeId);
+            $urlKey = $productResource->getAttributeRawValue($productId, 'url_key', $storeId);
+            if ($urlKey === $defaultUrlKey) {
+                continue;
+            }
             do {
                 $urlKey = $this->modifyUrl($urlKey);
                 $duplicate->setUrlKey($urlKey);

app/code/Magento/Catalog/Test/Unit/Model/Product/CopierTest.php

@@ -103,8 +103,44 @@ public function testCopy()
             ['linkField', null, '1'],
         ]);
 
-        $resourceMock = $this->createMock(\Magento\Catalog\Model\ResourceModel\Product::class);
-        $this->productMock->expects($this->once())->method('getResource')->will($this->returnValue($resourceMock));
+        $entityMock = $this->getMockForAbstractClass(
+                \Magento\Eav\Model\Entity\AbstractEntity::class,
+                [],
+                '',
+                false,
+                true,
+                true,
+                ['checkAttributeUniqueValue']
+            );
+        $entityMock->expects($this->any())
+            ->method('checkAttributeUniqueValue')
+            ->willReturn(true);
+
+        $attributeMock = $this->getMockForAbstractClass(
+                \Magento\Eav\Model\Entity\Attribute\AbstractAttribute::class,
+                [],
+                '',
+                false,
+                true,
+                true,
+                ['getEntity']
+            );
+        $attributeMock->expects($this->any())
+            ->method('getEntity')
+            ->willReturn($entityMock);
+
+        $resourceMock = $this->getMockBuilder(\Magento\Catalog\Model\ResourceModel\Product::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['getAttributeRawValue', 'duplicate', 'getAttribute'])
+            ->getMock();
+        $resourceMock->expects($this->any())
+            ->method('getAttributeRawValue')
+            ->willReturn('urk-key-1');
+        $resourceMock->expects($this->any())
+            ->method('getAttribute')
+            ->willReturn($attributeMock);
+
+        $this->productMock->expects($this->any())->method('getResource')->will($this->returnValue($resourceMock));
 
         $duplicateMock = $this->createPartialMock(
             Product::class,
@@ -119,11 +155,11 @@ public function testCopy()
                 'setCreatedAt',
                 'setUpdatedAt',
                 'setId',
-                'setStoreId',
                 'getEntityId',
                 'save',
                 'setUrlKey',
-                'getUrlKey',
+                'setStoreId',
+                'getStoreIds',
             ]
         );
         $this->productFactoryMock->expects($this->once())->method('create')->will($this->returnValue($duplicateMock));
@@ -138,27 +174,22 @@ public function testCopy()
         )->with(
             \Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS_DISABLED
         );
+        $duplicateMock->expects($this->atLeastOnce())->method('setStoreId');
         $duplicateMock->expects($this->once())->method('setCreatedAt')->with(null);
         $duplicateMock->expects($this->once())->method('setUpdatedAt')->with(null);
         $duplicateMock->expects($this->once())->method('setId')->with(null);
-        $duplicateMock->expects(
-            $this->once()
-        )->method(
-            'setStoreId'
-        )->with(
-            \Magento\Store\Model\Store::DEFAULT_STORE_ID
-        );
+        $duplicateMock->expects($this->atLeastOnce())->method('getStoreIds')->willReturn([]);
         $duplicateMock->expects($this->atLeastOnce())->method('setData')->willReturn($duplicateMock);
         $this->copyConstructorMock->expects($this->once())->method('build')->with($this->productMock, $duplicateMock);
-        $duplicateMock->expects($this->once())->method('getUrlKey')->willReturn('urk-key-1');
         $duplicateMock->expects($this->once())->method('setUrlKey')->with('urk-key-2')->willReturn($duplicateMock);
         $duplicateMock->expects($this->once())->method('save');
 
         $this->metadata->expects($this->any())->method('getLinkField')->willReturn('linkField');
 
         $duplicateMock->expects($this->any())->method('getData')->willReturnMap([
             ['linkField', null, '2'],
-        ]);        $this->optionRepositoryMock->expects($this->once())
+        ]);
+        $this->optionRepositoryMock->expects($this->once())
             ->method('duplicate')
             ->with($this->productMock, $duplicateMock);
         $resourceMock->expects($this->once())->method('duplicate')->with(1, 2);