Skip to content

Commit 55256fa

Browse files
🔃 [EngCom] Public Pull Requests - 2.3-develop
Accepted Public Pull Requests: - #15944: [Forwardport] Wrong annotation in _toOptionArray : lib\internal\Magento\Framework\D� (by @vgelani) - #15946: [Forwardport] ISSUE-11477 - fixed Swagger response for searchCriteria - added zero � (by @vgelani) - #15948: [Forwardport]No need to pass method parameter as method definition does not requir� (by @saurabh-aureate) Fixed GitHub Issues: - #11477: Magento REST API Schema (Swagger) is not compatible with Search Criteria (reported by @careys7) has been fixed in #15946 by @vgelani in 2.3-develop branch Related commits: 1. d76fe20
2 parents 33393e2 + 49ce545 commit 55256fa

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

app/code/Magento/UrlRewrite/Block/Catalog/Product/Edit.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ protected function _prepareLayoutFeatures()
5555
}
5656

5757
if ($this->_getProduct()->getId()) {
58-
$this->_addProductLinkBlock($this->_getProduct());
58+
$this->_addProductLinkBlock();
5959
}
6060

6161
if ($this->_getCategory()->getId()) {

app/code/Magento/Webapi/Model/Rest/Swagger/Generator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class Generator extends AbstractSchemaGenerator
3939
const UNAUTHORIZED_DESCRIPTION = '401 Unauthorized';
4040

4141
/** Array signifier */
42-
const ARRAY_SIGNIFIER = '[]';
42+
const ARRAY_SIGNIFIER = '[0]';
4343

4444
/**
4545
* Swagger factory instance.

lib/internal/Magento/Framework/Data/SearchResultProcessor.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,8 @@ public function toArray($arrRequiredFields = [])
188188
}
189189

190190
/**
191-
* @param null $valueField
192-
* @param null $labelField
191+
* @param string|null $valueField
192+
* @param string|null $labelField
193193
* @param array $additional
194194
* @return array
195195
*/

0 commit comments

Comments
 (0)