LYNX-445: Magento\TestFramework\TestCase\GraphQl\Client::processResponseHeaders() does not allow to process multiple Set-Cookie headers (#261)

Author: bl4de

dev/tests/api-functional/framework/Magento/TestFramework/TestCase/GraphQl/Client.php

@@ -22,6 +22,8 @@ class Client
     public const GRAPHQL_METHOD_POST = 'POST';
     /**#@-*/
 
+    private const SET_COOKIE_HEADER_NAME = 'Set-Cookie';
+
     /** @var CurlClient */
     private $curlClient;
 
@@ -264,7 +266,15 @@ private function processResponseHeaders(string $headers): array
         foreach ($headerLines as $headerLine) {
             $headerParts = preg_split('/: /', $headerLine, 2);
             if (count($headerParts) == 2) {
-                $headersArray[trim($headerParts[0])] = trim($headerParts[1]);
+                $headerName = trim($headerParts[0]);
+                if ($headerName === self::SET_COOKIE_HEADER_NAME) {
+                    if (!isset($headersArray[self::SET_COOKIE_HEADER_NAME])) {
+                        $headersArray[self::SET_COOKIE_HEADER_NAME] = [];
+                    }
+                    $headersArray[self::SET_COOKIE_HEADER_NAME][] = trim($headerParts[1]);
+                } else {
+                    $headersArray[$headerName] = trim($headerParts[1]);
+                }
             } elseif (preg_match('/HTTP\/[\.0-9]+/', $headerLine)) {
                 $headersArray[trim('Status-Line')] = trim($headerLine);
             }

dev/tests/Magento/GraphQl/PageCache/DisableSessionTest.php renamed to dev/tests/api-functional/testsuite/Magento/GraphQl/PageCache/DisableSessionTest.php

@@ -16,15 +16,17 @@
 
 namespace Magento\GraphQl\PageCache;
 
-use Magento\TestFramework\TestCase\GraphQlAbstract;
-use Magento\TestFramework\Fixture\Config;
 use Magento\Framework\App\PageCache\Version;
+use Magento\TestFramework\Fixture\Config;
+use Magento\TestFramework\TestCase\GraphQlAbstract;
 
 /**
  * Test absence/presence of private_content_version cookie in GraphQl POST HTTP responses
  */
 class DisableSessionTest extends GraphQlAbstract
 {
+    private const PHPSESSID_COOKIE_NAME = 'PHPSESSID';
+
     #[
         Config('graphql/session/disable', '1')
     ]
@@ -33,10 +35,14 @@ public function testPrivateSessionContentCookieNotPresentWhenSessionDisabled()
         $result = $this->graphQlMutationWithResponseHeaders($this->getMutation());
         $this->assertArrayHasKey('headers', $result);
         if (!empty($result['headers']['Set-Cookie'])) {
-            $this->assertStringNotContainsString(
-                Version::COOKIE_NAME,
-                $result['headers']['Set-Cookie'],
-                Version::COOKIE_NAME . ' should not be present in Set-Cookie header'
+            $this->assertFalse(
+                $this->isCookieSet($result['headers']['Set-Cookie'], self::PHPSESSID_COOKIE_NAME),
+                self::PHPSESSID_COOKIE_NAME . ' should not be present in HTTP response'
+            );
+
+            $this->assertFalse(
+                $this->isCookieSet($result['headers']['Set-Cookie'], Version::COOKIE_NAME),
+                Version::COOKIE_NAME . ' should not be present in HTTP response'
             );
         }
     }
@@ -49,11 +55,30 @@ public function testPrivateSessionContentCookiePresentWhenSessionEnabled()
         $result = $this->graphQlMutationWithResponseHeaders($this->getMutation());
         $this->assertArrayHasKey('headers', $result);
         $this->assertArrayHasKey('Set-Cookie', $result['headers'], 'Set-Cookie HTTP response header should be present');
-        $this->assertStringContainsString(
-            Version::COOKIE_NAME,
-            $result['headers']['Set-Cookie'],
-            Version::COOKIE_NAME . ' should be set by the server'
+
+        $this->assertTrue(
+            $this->isCookieSet($result['headers']['Set-Cookie'], self::PHPSESSID_COOKIE_NAME),
+            self::PHPSESSID_COOKIE_NAME . ' should be present in HTTP response'
         );
+
+        $this->assertTrue(
+            $this->isCookieSet($result['headers']['Set-Cookie'], Version::COOKIE_NAME),
+            Version::COOKIE_NAME . ' should be present in HTTP response'
+        );
+    }
+
+    /**
+     * Checks if $cookieName was set by server in any of Set-Cookie header(s)
+     *
+     * @param array $setCookieHeader
+     * @param string $cookieName
+     * @return bool
+     */
+    private function isCookieSet(array $setCookieHeader, string $cookieName): bool
+    {
+        return count(array_filter($setCookieHeader, function ($cookie) use ($cookieName) {
+            return str_starts_with($cookie, $cookieName);
+        })) > 0;
     }
 
     /**