Skip to content

Commit 58b25ca

Browse files
KevinBKozanKevinBKozan
committed
MQE-683: [Deprecation] Only use more nested assertion syntax
- Indent fixes
1 parent e7e2b44 commit 58b25ca

File tree

2 files changed

+33
-33
lines changed

2 files changed

+33
-33
lines changed

‎app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateCategoryTest.xml

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -70,35 +70,35 @@
7070
<seeOptionIsSelected selector="{{CategoryDesignSection.LayoutDropdown}}" userInput="2 columns with right bar" stepKey="see2ColumnsSelected" />
7171
</test>
7272
<test name="AdminCategoryFormDisplaySettingsUIValidationTest">
73-
<annotations>
74-
<features value="Catalog"/>
75-
<stories value="Default layout configuration MAGETWO-88793"/>
76-
<title value="Category should not be saved once layered navigation price step field is left empty"/>
77-
<description value="Once the Config setting is unchecked Category should not be saved with layered navigation price field left empty"/>
78-
<severity value="AVERAGE"/>
79-
<testCaseId value="MAGETWO-95797"/>
80-
<group value="category"/>
81-
</annotations>
82-
<before>
83-
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
84-
</before>
85-
<after>
86-
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
87-
</after>
88-
<amOnPage url="{{AdminCategoryPage.url}}" stepKey="navigateToCategoryPage"/>
89-
<waitForPageLoad time="30" stepKey="waitForPageLoad1"/>
90-
<click selector="{{AdminCategorySidebarActionSection.AddSubcategoryButton}}" stepKey="clickOnAddSubCategory"/>
91-
<fillField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="{{SimpleSubCategory.name}}" stepKey="enterCategoryName"/>
92-
<click selector="{{CategoryDisplaySettingsSection.DisplaySettingTab}}" stepKey="clickOnDisplaySettingsTab"/>
93-
<waitForElementVisible selector="{{CategoryDisplaySettingsSection.filterPriceRangeUseConfig}}" stepKey="wait"/>
94-
<scrollTo selector="{{CategoryDisplaySettingsSection.layeredNavigationPriceInput}}" stepKey="scrollToLayeredNavigationField"/>
95-
<uncheckOption selector="{{CategoryDisplaySettingsSection.filterPriceRangeUseConfig}}" stepKey="uncheckConfigSetting"/>
96-
<click selector="{{AdminCategoryMainActionsSection.SaveButton}}" stepKey="saveCategory"/>
97-
<see selector="{{AdminCategoryBasicFieldSection.FieldError('uid')}}" userInput="This is a required field." stepKey="seeErrorMessage"/>
98-
<!-- Verify that the Layered navigation price step field has the required indicator -->
99-
<comment userInput="Check if Layered navigation price field has required indicator icon" stepKey="comment" />
100-
<executeJS function="{{CategoryDisplaySettingsSection.RequiredFieldIndicator('filter_price_range')}}" stepKey="getRequiredFieldIndicator"/>
101-
<assertEquals message="pass" stepKey="assertRequiredFieldIndicator1">
73+
<annotations>
74+
<features value="Catalog"/>
75+
<stories value="Default layout configuration MAGETWO-88793"/>
76+
<title value="Category should not be saved once layered navigation price step field is left empty"/>
77+
<description value="Once the Config setting is unchecked Category should not be saved with layered navigation price field left empty"/>
78+
<severity value="AVERAGE"/>
79+
<testCaseId value="MAGETWO-95797"/>
80+
<group value="category"/>
81+
</annotations>
82+
<before>
83+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
84+
</before>
85+
<after>
86+
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
87+
</after>
88+
<amOnPage url="{{AdminCategoryPage.url}}" stepKey="navigateToCategoryPage"/>
89+
<waitForPageLoad time="30" stepKey="waitForPageLoad1"/>
90+
<click selector="{{AdminCategorySidebarActionSection.AddSubcategoryButton}}" stepKey="clickOnAddSubCategory"/>
91+
<fillField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="{{SimpleSubCategory.name}}" stepKey="enterCategoryName"/>
92+
<click selector="{{CategoryDisplaySettingsSection.DisplaySettingTab}}" stepKey="clickOnDisplaySettingsTab"/>
93+
<waitForElementVisible selector="{{CategoryDisplaySettingsSection.filterPriceRangeUseConfig}}" stepKey="wait"/>
94+
<scrollTo selector="{{CategoryDisplaySettingsSection.layeredNavigationPriceInput}}" stepKey="scrollToLayeredNavigationField"/>
95+
<uncheckOption selector="{{CategoryDisplaySettingsSection.filterPriceRangeUseConfig}}" stepKey="uncheckConfigSetting"/>
96+
<click selector="{{AdminCategoryMainActionsSection.SaveButton}}" stepKey="saveCategory"/>
97+
<see selector="{{AdminCategoryBasicFieldSection.FieldError('uid')}}" userInput="This is a required field." stepKey="seeErrorMessage"/>
98+
<!-- Verify that the Layered navigation price step field has the required indicator -->
99+
<comment userInput="Check if Layered navigation price field has required indicator icon" stepKey="comment" />
100+
<executeJS function="{{CategoryDisplaySettingsSection.RequiredFieldIndicator('filter_price_range')}}" stepKey="getRequiredFieldIndicator"/>
101+
<assertEquals message="pass" stepKey="assertRequiredFieldIndicator1">
102102
<actualResult type="variable">getRequiredFieldIndicator</actualResult>
103103
<expectedResult type="string">"*"</expectedResult>
104104
</assertEquals>

‎app/code/Magento/Sales/Test/Mftf/Test/StorefrontPrintOrderGuestTest.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@
117117
</actionGroup>
118118
<grabTextFrom selector="{{AdminConfigurableProductFormSection.currentAttribute}}" stepKey="grabAttribute"/>
119119
<assertNotEmpty stepKey="assertNotEmpty">
120-
<actualResult type="const">$grabAttribute</actualResult>
121-
</assertNotEmpty>
120+
<actualResult type="const">$grabAttribute</actualResult>
121+
</assertNotEmpty>
122122

123123
<!-- Create bundle Product -->
124124
<createData entity="SimpleSubCategory" stepKey="createSubCategory"/>
@@ -152,8 +152,8 @@
152152
</actionGroup>
153153
<grabTextFrom selector="{{AdminProductFormBundleSection.currentBundleOption}}" stepKey="grabBundleOption"/>
154154
<assertNotEmpty stepKey="assertBundleOptionNotEmpty">
155-
<actualResult type="const">$grabBundleOption</actualResult>
156-
</assertNotEmpty>
155+
<actualResult type="const">$grabBundleOption</actualResult>
156+
</assertNotEmpty>
157157

158158
<!-- Create sales rule -->
159159
<createData entity="ActiveSalesRuleCoupon50" stepKey="createCartPriceRule"/>

0 commit comments

Comments
 (0)