#28570: createCustomer does not match validation requirements

Author: michalderlatka

app/code/Magento/CustomerGraphQl/Model/Resolver/UpdateCustomerEmail.php

@@ -25,10 +25,12 @@ class UpdateCustomerEmail implements ResolverInterface
      * @var GetCustomer
      */
     private $getCustomer;
+
     /**
      * @var UpdateCustomerAccount
      */
     private $updateCustomerAccount;
+
     /**
      * @var ExtractCustomerData
      */
@@ -50,7 +52,7 @@ public function __construct(
     }
 
     /**
-     * @inheritdoc
+     * Resolves customer email update mutation
      */
     public function resolve(
         Field $field,
@@ -67,7 +69,10 @@ public function resolve(
         $customer = $this->getCustomer->execute($context);
         $this->updateCustomerAccount->execute(
             $customer,
-            ['email' => $args['email'], 'password' => $args['password']],
+            [
+                'email' => $args['email'] ?? null,
+                'password' => $args['password'] ?? null
+            ],
             $context->getExtensionAttributes()->getStore()
         );
 

app/code/Magento/CustomerGraphQl/etc/schema.graphqls

@@ -17,7 +17,8 @@ type Query {
 type Mutation {
     generateCustomerToken(email: String!, password: String!): CustomerToken @resolver(class: "\\Magento\\CustomerGraphQl\\Model\\Resolver\\GenerateCustomerToken") @doc(description:"Retrieve the customer token")
     changeCustomerPassword(currentPassword: String!, newPassword: String!): Customer @resolver(class: "\\Magento\\CustomerGraphQl\\Model\\Resolver\\ChangePassword") @doc(description:"Changes the password for the logged-in customer")
-    createCustomer (input: CustomerCreateInput!): CustomerOutput @resolver(class: "\\Magento\\CustomerGraphQl\\Model\\Resolver\\CreateCustomer") @doc(description:"Create customer account")
+    createCustomer (input: CustomerInput!): CustomerOutput @resolver(class: "\\Magento\\CustomerGraphQl\\Model\\Resolver\\CreateCustomer") @doc(description:"Create customer account")
+    createCustomerV2 (input: CustomerCreateInput!): CustomerOutput @resolver(class: "\\Magento\\CustomerGraphQl\\Model\\Resolver\\CreateCustomer") @doc(description:"Create customer account")
     updateCustomer (input: CustomerInput!): CustomerOutput @resolver(class: "\\Magento\\CustomerGraphQl\\Model\\Resolver\\UpdateCustomer") @doc(description:"Deprecated. Use UpdateCustomerV2 instead.")
     updateCustomerV2 (input: CustomerUpdateInput!): CustomerOutput @resolver(class: "\\Magento\\CustomerGraphQl\\Model\\Resolver\\UpdateCustomer") @doc(description:"Update the customer's personal information")
     revokeCustomerToken: RevokeCustomerTokenOutput @resolver(class: "\\Magento\\CustomerGraphQl\\Model\\Resolver\\RevokeCustomerToken") @doc(description:"Revoke the customer token")

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/CreateCustomerTest.php

@@ -116,12 +116,8 @@ public function testCreateCustomerAccountWithoutPassword()
      */
     public function testCreateCustomerIfInputDataIsEmpty()
     {
-        $exceptionMessage = 'Field CustomerCreateInput.email of required type String! was not provided.
-Field CustomerCreateInput.firstname of required type String! was not provided.
-Field CustomerCreateInput.lastname of required type String! was not provided.';
-
         $this->expectException(\Exception::class);
-        $this->expectExceptionMessage($exceptionMessage);
+        $this->expectExceptionMessage('"input" value should be specified');
 
         $query = <<<QUERY
 mutation {
@@ -148,7 +144,7 @@ public function testCreateCustomerIfInputDataIsEmpty()
     public function testCreateCustomerIfEmailMissed()
     {
         $this->expectException(\Exception::class);
-        $this->expectExceptionMessage('Field CustomerCreateInput.email of required type String! was not provided');
+        $this->expectExceptionMessage('Required parameters are missing: Email');
 
         $newFirstname = 'Richard';
         $newLastname = 'Rowe';
@@ -238,7 +234,7 @@ public function invalidEmailAddressDataProvider(): array
     public function testCreateCustomerIfPassedAttributeDosNotExistsInCustomerInput()
     {
         $this->expectException(\Exception::class);
-        $this->expectExceptionMessage('Field "test123" is not defined by type CustomerCreateInput.');
+        $this->expectExceptionMessage('Field "test123" is not defined by type CustomerInput.');
 
         $newFirstname = 'Richard';
         $newLastname = 'Rowe';