Skip to content

Commit 5f05166

Browse files
authored
Merge pull request #6833 from magento-lynx/tinymce3
[Lynx] Removed TinyMCE v3
2 parents 5eef670 + 574d9f8 commit 5f05166

File tree

387 files changed

+960
-102459
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

387 files changed

+960
-102459
lines changed

app/code/Magento/Cms/Test/Mftf/Data/WysiwygConfigData.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,6 @@
1818
<data key="scope_id">0</data>
1919
<data key="value">disabled</data>
2020
</entity>
21-
<entity name="WysiwygTinyMCE3Enable" deprecated="Use WysiwygTinyMCE4Enable instead">
22-
<data key="path">cms/wysiwyg/editor</data>
23-
<data key="scope_id">0</data>
24-
<data key="value">Magento_Tinymce3/tinymce3Adapter</data>
25-
</entity>
2621
<entity name="WysiwygTinyMCE4Enable">
2722
<data key="path">cms/wysiwyg/editor</data>
2823
<data key="scope_id">0</data>

app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection/MediaGallerySection.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
<element name="imageSelected" type="text" selector="//small[text()='{{var1}}']/parent::*[@class='filecnt selected']" parameterized="true"/>
1818
<element name="ImageSource" type="input" selector=".mce-combobox.mce-abs-layout-item.mce-last.mce-has-open"/>
1919
<element name="ImageDescription" type="input" selector=".mce-textbox.mce-abs-layout-item.mce-last"/>
20-
<element name="ImageDescriptionTinyMCE3" type="input" selector="#alt" deprecated="Deprecated New element was introduced. Please use 'ImageDescriptionTinyMCE4'"/>
2120
<element name="ImageDescriptionTinyMCE4" type="input" selector="#alt" />
2221
<element name="Height" type="input" selector=".mce-textbox.mce-abs-layout-item.mce-first"/>
2322
<element name="UploadImage" type="file" selector=".fileupload"/>

app/code/Magento/Cms/Test/Mftf/Test/AdminAddImageToCMSPageTinyMCE3Test.xml

Lines changed: 0 additions & 79 deletions
This file was deleted.

app/code/Magento/Config/Test/Mftf/ActionGroup/SwitchToTinyMCE3ActionGroup.xml

Lines changed: 0 additions & 26 deletions
This file was deleted.

app/code/Magento/MediaGalleryIntegration/Test/Integration/Model/TinyMceOpenDialogUrlTest.php renamed to app/code/Magento/MediaGalleryIntegration/Test/Integration/Model/GalleryConfigProviderOpenDialogUrlTest.php

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,30 +8,33 @@
88

99
namespace Magento\MediaGalleryIntegration\Test\Integration\Model;
1010

11+
use Magento\Cms\Model\Wysiwyg\Config;
12+
use Magento\Cms\Model\Wysiwyg\Gallery\DefaultConfigProvider;
13+
use Magento\Cms\Helper\Wysiwyg\Images;
1114
use Magento\Framework\DataObject;
1215
use Magento\Framework\ObjectManagerInterface;
1316
use Magento\Framework\UrlInterface;
1417
use Magento\TestFramework\Helper\Bootstrap;
15-
use Magento\Tinymce3\Model\Config\Gallery\Config;
1618
use PHPUnit\Framework\TestCase;
1719

1820
/**
1921
* Provide integration tests cover update open dialog url functionality for media editor.
2022
* @magentoAppArea adminhtml
2123
*/
22-
class TinyMceOpenDialogUrlTest extends TestCase
24+
class GalleryConfigProviderOpenDialogUrlTest extends TestCase
2325
{
2426
private const FILES_BROWSER_WINDOW_URL = 'files_browser_window_url';
27+
private const MEDIA_GALLERY_URL = 'media_gallery/index/index';
2528

2629
/**
2730
* @var ObjectManagerInterface
2831
*/
2932
private $objectManger;
3033

3134
/**
32-
* @var Config
35+
* @var DefaultConfigProvider
3336
*/
34-
private $tinyMce3Config;
37+
private $galleryConfigProvider;
3538

3639
/**
3740
* @var DataObject
@@ -49,11 +52,17 @@ class TinyMceOpenDialogUrlTest extends TestCase
4952
protected function setUp(): void
5053
{
5154
$this->objectManger = Bootstrap::getObjectManager();
52-
$this->tinyMce3Config = $this->objectManger->create(Config::class);
55+
$this->galleryConfigProvider = $this->objectManger->create(DefaultConfigProvider::class);
5356
$this->configDataObject = $this->objectManger->create(DataObject::class);
5457

5558
$url = $this->objectManger->create(UrlInterface::class);
56-
$this->fileBrowserWindowUrl = $url->getUrl('media_gallery/index/index');
59+
60+
$this->fileBrowserWindowUrl = $url->getUrl(
61+
self::MEDIA_GALLERY_URL,
62+
[
63+
'current_tree_path' => $this->objectManger->get(Images::class)->idEncode(Config::IMAGE_DIRECTORY),
64+
]
65+
);
5766
}
5867

5968
/**
@@ -62,7 +71,7 @@ protected function setUp(): void
6271
*/
6372
public function testWithEnhancedMediaGalleryDisabled(): void
6473
{
65-
$config = $this->tinyMce3Config->getConfig($this->configDataObject);
74+
$config = $this->galleryConfigProvider->getConfig($this->configDataObject);
6675
self::assertNotEquals($this->fileBrowserWindowUrl, $config->getData(self::FILES_BROWSER_WINDOW_URL));
6776
}
6877

@@ -72,7 +81,7 @@ public function testWithEnhancedMediaGalleryDisabled(): void
7281
*/
7382
public function testWithEnhancedMediaGalleryEnabled(): void
7483
{
75-
$config = $this->tinyMce3Config->getConfig($this->configDataObject);
84+
$config = $this->galleryConfigProvider->getConfig($this->configDataObject);
7685
self::assertEquals($this->fileBrowserWindowUrl, $config->getData(self::FILES_BROWSER_WINDOW_URL));
7786
}
7887
}

0 commit comments

Comments
 (0)