Skip to content

Commit 68c41a5

Browse files
author
Joan He
committed
Merge remote-tracking branch 'upstream/develop' into develop
2 parents 4e4a369 + adf0cbe commit 68c41a5

File tree

6 files changed

+8
-25
lines changed

6 files changed

+8
-25
lines changed

app/code/Magento/Catalog/Controller/Adminhtml/Product/MassStatus.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public function _validateMassStatus(array $productIds, $status)
5757
*/
5858
public function execute()
5959
{
60-
$productIds = (array) $this->getRequest()->getParam('product');
60+
$productIds = (array) $this->getRequest()->getParam('selected');
6161
$storeId = (int) $this->getRequest()->getParam('store', 0);
6262
$status = (int) $this->getRequest()->getParam('status');
6363

app/code/Magento/Catalog/view/adminhtml/ui_component/product_listing.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,12 +210,12 @@
210210
<item name="0" xsi:type="array">
211211
<item name="type" xsi:type="string">enable</item>
212212
<item name="label" xsi:type="string" translate="true">Enable</item>
213-
<item name="url" xsi:type="string">catalog/product/massEnable</item>
213+
<item name="url" xsi:type="string">catalog/product/massStatus/status/1</item>
214214
</item>
215215
<item name="1" xsi:type="array">
216216
<item name="type" xsi:type="string">disable</item>
217217
<item name="label" xsi:type="string" translate="true">Disable</item>
218-
<item name="url" xsi:type="string">catalog/product/massDisable</item>
218+
<item name="url" xsi:type="string">catalog/product/massStatus/status/2</item>
219219
</item>
220220
</item>
221221
</item>

app/code/Magento/CatalogInventory/Ui/DataProvider/Product/AddQuantityFilterToCollection.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,16 @@ class AddQuantityFilterToCollection implements AddFilterToCollectionInterface
1919
*/
2020
public function addFilter(Collection $collection, $field, $condition = null)
2121
{
22-
if (isset($condition['from'])) {
22+
if (isset($condition['gteq'])) {
2323
$collection->getSelect()->where(
2424
AbstractCollection::ATTRIBUTE_TABLE_ALIAS_PREFIX . 'qty.qty >= ?',
25-
(float)$condition['from']
25+
(float)$condition['gteq']
2626
);
2727
}
28-
if ($condition['to']) {
28+
if (isset($condition['lteq'])) {
2929
$collection->getSelect()->where(
3030
AbstractCollection::ATTRIBUTE_TABLE_ALIAS_PREFIX . 'qty.qty <= ?',
31-
(float)$condition['to']
31+
(float)$condition['lteq']
3232
);
3333
}
3434
}

app/code/Magento/Eav/Model/Entity/AbstractEntity.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1262,6 +1262,7 @@ protected function _collectSaveData($newObject)
12621262

12631263
if (!$attribute->isInSet($newObject->getAttributeSetId()) && !in_array($k, $staticFields)) {
12641264
$this->_aggregateDeleteData($delete, $attribute, $newObject);
1265+
continue;
12651266
}
12661267

12671268
$attrId = $attribute->getAttributeId();

app/code/Magento/Eav/Test/Unit/Model/Entity/AbstractEntityTest.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,6 @@ public function testSave($attributeCode, $attributeSetId, $productData, $product
239239
'getAffectedFields',
240240
'isStatic',
241241
'getEntityValueId',
242-
'getEntityIdField'
243242
]
244243
);
245244

@@ -255,14 +254,6 @@ public function testSave($attributeCode, $attributeSetId, $productData, $product
255254

256255
$backendModel->expects($this->never())->method('getEntityValueId');
257256

258-
$backendModel->expects(
259-
isset($productData['entity_id']) ? $this->never() : $this->once()
260-
)->method(
261-
'getEntityIdField'
262-
)->will(
263-
$this->returnValue('entity_id')
264-
);
265-
266257
$backendModel->setAttribute($attribute);
267258
$attribute->expects($this->any())->method('getBackend')->will($this->returnValue($backendModel));
268259
$attribute->setId(222);

app/code/Magento/Eav/Test/Unit/Model/Entity/VersionControl/AbstractEntityTest.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ public function testSave($attributeCode, $attributeSetId, $productData, $product
8888
'getAffectedFields',
8989
'isStatic',
9090
'getEntityValueId',
91-
'getEntityIdField'
9291
]
9392
);
9493

@@ -102,14 +101,6 @@ public function testSave($attributeCode, $attributeSetId, $productData, $product
102101

103102
$backendModel->expects($this->any())->method('isStatic')->will($this->returnValue(false));
104103
$backendModel->expects($this->never())->method('getEntityValueId');
105-
$backendModel->expects(
106-
isset($productData['entity_id']) ? $this->never() : $this->once()
107-
)->method(
108-
'getEntityIdField'
109-
)->will(
110-
$this->returnValue('entity_id')
111-
);
112-
113104
$backendModel->setAttribute($attribute);
114105

115106
$attribute->expects($this->any())->method('getBackend')->will($this->returnValue($backendModel));

0 commit comments

Comments
 (0)