MAGETWO-86630: Magento 2.2 Develop fix for #12221 Google Analytics Pageview Triggered twice #13034

dmanners · dmanners · commit 6c58188f1dd0 · 2018-01-11T03:34:49.000-06:00
- Merge Pull Request #13034 from bhargavmehta/magento2:2.2-dev-fix - Merged commits: 1. 149d08f 2. e851948
diff --git a/app/code/Magento/GoogleAnalytics/view/frontend/web/js/google-analytics.js b/app/code/Magento/GoogleAnalytics/view/frontend/web/js/google-analytics.js
@@ -51,10 +51,9 @@ define([
             if (config.pageTrackingData.isAnonymizedIpActive) {
                 ga('set', 'anonymizeIp', true);
             }
-            ga('send', 'pageview' + config.pageTrackingData.optPageUrl);
 
             // Process orders data
-            if (config.ordersTrackingData) {
+            if (config.ordersTrackingData.length) {
                 ga('require', 'ec', 'ec.js');
 
                 //Set currency code
@@ -75,6 +74,9 @@ define([
                 }
 
                 ga('send', 'pageview');
+            }else{
+                // Process Data if not orders
+                ga('send', 'pageview' + config.pageTrackingData.optPageUrl);
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,9 @@ define([`
`51`	`51`	`if (config.pageTrackingData.isAnonymizedIpActive) {`
`52`	`52`	`ga('set', 'anonymizeIp', true);`
`53`	`53`	`}`
`54`		`- ga('send', 'pageview' + config.pageTrackingData.optPageUrl);`
`55`	`54`
`56`	`55`	`// Process orders data`
`57`		`- if (config.ordersTrackingData) {`
	`56`	`+ if (config.ordersTrackingData.length) {`
`58`	`57`	`ga('require', 'ec', 'ec.js');`
`59`	`58`
`60`	`59`	`//Set currency code`
`@@ -75,6 +74,9 @@ define([`
`75`	`74`	`}`
`76`	`75`
`77`	`76`	`ga('send', 'pageview');`
	`77`	`+ }else{`
	`78`	`+ // Process Data if not orders`
	`79`	`+ ga('send', 'pageview' + config.pageTrackingData.optPageUrl);`
`78`	`80`	`}`
`79`	`81`	`}`
`80`	`82`	`}`