Make builds repeatable

Sort all configs in generated/metadata before writing to file

Author: ihor-sviziev

lib/internal/Magento/Framework/Interception/Config/CacheManager.php

@@ -88,6 +88,9 @@ public function save(string $key, array $data)
      */
     public function saveCompiled(string $key, array $data)
     {
+        // sort configuration to have it in the same order on every build
+        ksort($data);
+
         $this->configWriter->write($key, $data);
     }
 

setup/src/Magento/Setup/Module/Di/App/Task/Operation/AppActionListGenerator.php

@@ -20,7 +20,7 @@ class AppActionListGenerator implements OperationInterface
     private $moduleReader;
 
     /**
-     * @var \Magento\Framework\App\ObjectManager\ConfigWriterInterface
+     * @var ConfigWriterInterface
      */
     private $configWriter;
 
@@ -42,10 +42,11 @@ public function __construct(
     public function doOperation()
     {
         $actionList = $this->moduleReader->getActionFiles();
-        $this->configWriter->write(
-            'app_action_list',
-            $actionList
-        );
+
+        // sort configuration to have it in the same order on every build
+        ksort($actionList);
+
+        $this->configWriter->write('app_action_list', $actionList);
     }
 
     /**

setup/src/Magento/Setup/Module/Di/App/Task/Operation/Area.php

@@ -95,10 +95,12 @@ public function doOperation()
             $config = $this->configReader->generateCachePerScope($definitionsCollection, $areaCode);
             $config = $this->modificationChain->modify($config);
 
-            $this->configWriter->write(
-                $areaCode,
-                $config
-            );
+            // sort configuration to have it in the same order on every build
+            ksort($config['arguments']);
+            ksort($config['preferences']);
+            ksort($config['instanceTypes']);
+
+            $this->configWriter->write($areaCode, $config);
         }
     }
 

setup/src/Magento/Setup/Module/Di/App/Task/Operation/PluginListGenerator.php

@@ -47,6 +47,9 @@ public function doOperation()
         // remove primary scope for production mode as it is only called in developer mode
         $scopes = array_diff($scopes, ['primary']);
 
+        // sort configuration to have it in the same order on every build
+        ksort($scopes);
+
         $this->configWriter->write($scopes);
     }
 

setup/src/Magento/Setup/Module/Di/Compiler/Config/Reader.php

@@ -100,11 +100,6 @@ public function generateCachePerScope(
             $config['instanceTypes'][$virtualType] = $areaConfig->getInstanceType($virtualType);
         }
 
-        // sort configuration to have it in the same order on every build
-        ksort($config['arguments']);
-        ksort($config['preferences']);
-        ksort($config['instanceTypes']);
-
         return $config;
     }