Skip to content

Commit 6d04ead

Browse files
authored
ENGCOM-6284: Fixed issue when escape key is pressed to close prompt #25349
2 parents ca6ec09 + f29aebb commit 6d04ead

File tree

2 files changed

+13
-10
lines changed

2 files changed

+13
-10
lines changed

app/code/Magento/Ui/view/base/web/js/modal/modal.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ define([
308308
* Close modal.
309309
* * @return {Element} - current element.
310310
*/
311-
closeModal: function () {
311+
closeModal: function (event, result) {//eslint-disable-line no-unused-vars
312312
var that = this;
313313

314314
this._removeKeyListener();

app/code/Magento/Ui/view/base/web/js/modal/prompt.js

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ define([
5151
/**
5252
* Click handler.
5353
*/
54-
click: function () {
55-
this.closeModal();
54+
click: function (event) {
55+
this.closeModal(event);
5656
}
5757
}, {
5858
text: $.mage.__('OK'),
@@ -61,8 +61,8 @@ define([
6161
/**
6262
* Click handler.
6363
*/
64-
click: function () {
65-
this.closeModal(true);
64+
click: function (event) {
65+
this.closeModal(event, true);
6666
}
6767
}]
6868
},
@@ -75,7 +75,7 @@ define([
7575
this.options.validation = this.options.validation && this.options.validationRules.length;
7676
this._super();
7777
this.modal.find(this.options.modalContent).append(this.getFormTemplate());
78-
this.modal.find(this.options.modalCloseBtn).off().on('click', _.bind(this.closeModal, this, false));
78+
this.modal.find(this.options.modalCloseBtn).off().on('click', _.bind(this.closeModal, this));
7979

8080
if (this.options.validation) {
8181
this.setValidationClasses();
@@ -152,21 +152,23 @@ define([
152152
/**
153153
* Close modal window
154154
*/
155-
closeModal: function (result) {
155+
closeModal: function (event, result) {
156156
var value;
157157

158+
result = result || false;
159+
158160
if (result) {
159161
if (this.options.validation && !this.validate()) {
160162
return false;
161163
}
162164

163165
value = this.modal.find(this.options.promptField).val();
164-
this.options.actions.confirm.call(this, value);
166+
this.options.actions.confirm.call(event, value);
165167
} else {
166-
this.options.actions.cancel.call(this, result);
168+
this.options.actions.cancel.call(event, result);
167169
}
168170

169-
this.options.actions.always();
171+
this.options.actions.always(event);
170172
this.element.bind('promptclosed', _.bind(this._remove, this));
171173

172174
return this._super();
@@ -177,3 +179,4 @@ define([
177179
return $('<div class="prompt-message"></div>').html(config.content).prompt(config);
178180
};
179181
});
182+

0 commit comments

Comments
 (0)