Skip to content

Commit 6d959c7

Browse files
author
Yaroslav Voronoy
committed
2 parents 47970ab + ce89725 commit 6d959c7

File tree

20 files changed

+334
-608
lines changed

20 files changed

+334
-608
lines changed

app/code/Magento/Cron/etc/di.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,11 @@
3636
</argument>
3737
</arguments>
3838
</type>
39+
<type name="Magento\Framework\App\AreaList">
40+
<arguments>
41+
<argument name="areas" xsi:type="array">
42+
<item name="crontab" xsi:type="null" />
43+
</argument>
44+
</arguments>
45+
</type>
3946
</config>

app/code/Magento/PageCache/Model/App/FrontController/MessageBox.php

Lines changed: 0 additions & 100 deletions
This file was deleted.

app/code/Magento/PageCache/Test/Unit/Model/App/FrontController/MessageBoxTest.php

Lines changed: 0 additions & 148 deletions
This file was deleted.

app/code/Magento/PageCache/etc/frontend/di.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
<type name="Magento\Framework\App\FrontControllerInterface">
1010
<plugin name="front-controller-builtin-cache" type="Magento\PageCache\Model\App\FrontController\BuiltinPlugin"/>
1111
<plugin name="front-controller-varnish-cache" type="Magento\PageCache\Model\App\FrontController\VarnishPlugin"/>
12-
<plugin name="front-controller-message-box" type="Magento\PageCache\Model\App\FrontController\MessageBox" sortOrder="0"/>
1312
</type>
1413
<type name="Magento\Framework\Controller\ResultInterface">
1514
<plugin name="result-builtin-cache" type="Magento\PageCache\Model\Controller\Result\BuiltinPlugin"/>

app/code/Magento/PageCache/view/frontend/web/js/page-cache.js

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -51,28 +51,6 @@ define([
5151
return elements;
5252
};
5353

54-
/**
55-
* MsgBox Widget checks if message box is displayed and sets cookie
56-
*/
57-
$.widget('mage.msgBox', {
58-
options: {
59-
msgBoxCookieName: 'message_box_display',
60-
msgBoxSelector: '.main div.messages'
61-
},
62-
63-
/**
64-
* Creates widget 'mage.msgBox'
65-
* @private
66-
*/
67-
_create: function () {
68-
if ($.mage.cookies.get(this.options.msgBoxCookieName)) {
69-
$.mage.cookies.clear(this.options.msgBoxCookieName);
70-
} else {
71-
$(this.options.msgBoxSelector).hide();
72-
}
73-
}
74-
});
75-
7654
/**
7755
* FormKey Widget - this widget is generating from key, saves it to cookie and
7856
*/
@@ -272,14 +250,12 @@ define([
272250

273251
domReady(function () {
274252
$('body')
275-
.msgBox()
276253
.formKey();
277254
});
278255

279256
return {
280257
'pageCache': $.mage.pageCache,
281-
'formKey': $.mage.formKey,
282-
'msgBox': $.mage.msgBox
258+
'formKey': $.mage.formKey
283259
};
284260

285261
/**

dev/tests/integration/testsuite/Magento/Setup/Model/UpdatePackagesCacheTest.php

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,10 @@
66

77
namespace Magento\Setup\Model;
88

9-
use Magento\Framework\App\Filesystem\DirectoryList;
109
use Magento\TestFramework\Helper\Bootstrap;
1110
use Magento\Framework\Composer\ComposerJsonFinder;
1211
use Magento\Framework\Composer\MagentoComposerApplicationFactory;
13-
use Magento\Framework\Stdlib\DateTime\DateTime;
12+
use Magento\Setup\Model\UpdatePackagesCache;
1413

1514
/**
1615
* Tests Magento\Framework\ComposerInformation
@@ -88,19 +87,19 @@ public function testGetPackagesForUpdate()
8887
->method('get')
8988
->willReturn($this->objectManager);
9089

91-
/** @var \Magento\Setup\Model\UpdatePackagesCache $updatePackagesCache */
92-
$updatePackagesCache = $this->objectManager->create(
93-
'Magento\Setup\Model\UpdatePackagesCache',
94-
[
95-
'applicationFactory' => new MagentoComposerApplicationFactory(
96-
$this->composerJsonFinder,
97-
$this->directoryList
98-
),
99-
'filesystem' => $this->filesystem,
100-
'composerInformation' => $this->composerInformation,
101-
'objectManagerProvider' => $objectManagerProvider,
90+
/** @var UpdatePackagesCache $updatePackagesCache|\PHPUnit_Framework_MockObject_MockObject */
91+
$updatePackagesCache = $this->getMock('Magento\Setup\Model\UpdatePackagesCache', [], [], '', false);
92+
93+
$packages = [
94+
'packages' => [
95+
$packageName => [
96+
'latestVersion' => '1000.100.200'
97+
]
10298
]
103-
);
99+
];
100+
101+
$updatePackagesCache->expects($this->once())->method('syncPackagesForUpdate')->willReturn(true);
102+
$updatePackagesCache->expects($this->once())->method('getPackagesForUpdate')->willReturn($packages);
104103

105104
$requiredPackages = $this->composerInformation->getInstalledMagentoPackages();
106105
$this->assertArrayHasKey($packageName, $requiredPackages);

0 commit comments

Comments
 (0)