Skip to content

Commit 730e198

Browse files
author
Idolov, Stanislav(sidolov)
committed
Merge pull request #350 from magento-folks/MAGETWO-48544
[Folks] Public GitHub Pull Request Processing
2 parents 9368ecf + c9c8f80 commit 730e198

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

app/code/Magento/Backend/Block/Widget/Tabs.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public function addTabAfter($tabId, $tab, $afterTabId)
112112
public function addTab($tabId, $tab)
113113
{
114114
if (empty($tabId)) {
115-
throw new \Exception(__('Please correct the tab configuration and try again. Tab Id should be not empry'));
115+
throw new \Exception(__('Please correct the tab configuration and try again. Tab Id should be not empty'));
116116
}
117117
if (is_array($tab)) {
118118
$this->_tabs[$tabId] = new \Magento\Framework\DataObject($tab);

app/code/Magento/Checkout/Model/Type/Onepage.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,9 @@ public function saveShipping($data, $customerAddressId)
445445
if (!isset($data[$attributeCode])) {
446446
$address->setData($attributeCode, null);
447447
} else {
448-
$address->setDataUsingMethod($attributeCode, $compactedData[$attributeCode]);
448+
if (isset($compactedData[$attributeCode])) {
449+
$address->setDataUsingMethod($attributeCode, $compactedData[$attributeCode]);
450+
}
449451
}
450452
}
451453

app/code/Magento/Checkout/view/frontend/layout/checkout_cart_index.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,9 @@
183183
</block>
184184
</container>
185185
<container name="checkout.cart.noitems" as="no-items">
186-
<block class="Magento\Checkout\Block\Cart" name="checkout.cart.empty" before="-" template="cart/noItems.phtml"/>
187-
<container name="checkout.cart.empty.widget" as="checkout_cart_empty_widget" label="Empty Shopping Cart Content Before"/>
186+
<block class="Magento\Checkout\Block\Cart" name="checkout.cart.empty" before="-" template="cart/noItems.phtml">
187+
<container name="checkout.cart.empty.widget" as="checkout_cart_empty_widget" label="Empty Shopping Cart Content Before"/>
188+
</block>
188189
</container>
189190
</block>
190191
</referenceContainer>

app/code/Magento/Eav/Model/Entity/Collection/AbstractCollection.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1514,7 +1514,7 @@ public function setOrder($attribute, $dir = self::SORT_ORDER_ASC)
15141514
public function toArray($arrAttributes = [])
15151515
{
15161516
$arr = [];
1517-
foreach ($this->_items as $key => $item) {
1517+
foreach ($this->getItems() as $key => $item) {
15181518
$arr[$key] = $item->toArray($arrAttributes);
15191519
}
15201520
return $arr;

0 commit comments

Comments
 (0)