Skip to content

Commit 7322e87

Browse files
Merge pull request #5262 from magento-obsessive-owls/PR-2.4
[Owls] Bugfix
2 parents 606c3e8 + aa7a519 commit 7322e87

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

app/code/Magento/CatalogInventory/Model/Source/Stock.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public function getAllOptions()
4242
public function addValueSortToCollection($collection, $dir = \Magento\Framework\Data\Collection::SORT_ORDER_DESC)
4343
{
4444
$collection->getSelect()->joinLeft(
45-
['stock_item_table' => 'cataloginventory_stock_item'],
45+
['stock_item_table' => $collection->getTable('cataloginventory_stock_item')],
4646
"e.entity_id=stock_item_table.product_id",
4747
[]
4848
);

app/code/Magento/CatalogInventory/Test/Unit/Model/Source/StockTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ public function testAddValueSortToCollection()
2525
$selectMock = $this->createMock(\Magento\Framework\DB\Select::class);
2626
$collectionMock = $this->createMock(\Magento\Eav\Model\Entity\Collection\AbstractCollection::class);
2727
$collectionMock->expects($this->atLeastOnce())->method('getSelect')->willReturn($selectMock);
28+
$collectionMock->expects($this->atLeastOnce())->method('getTable')->willReturn('cataloginventory_stock_item');
2829

2930
$selectMock->expects($this->once())
3031
->method('joinLeft')

app/code/Magento/Ui/view/base/web/js/modal/modal.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ define([
192192
* @param {String} title
193193
*/
194194
setTitle: function (title) {
195-
var $title = $(this.options.modalTitle),
195+
var $title = this.modal.find(this.options.modalTitle),
196196
$subTitle = this.modal.find(this.options.modalSubTitle);
197197

198198
$title.text(title);

0 commit comments

Comments
 (0)