Update Store getConfig() to respect valid false return value

Jeroen · Jeroen van Leusden · commit 73ca3548ed5e · 2018-02-14T12:22:16.000+01:00
Using a config setting Yes/No will return string '0' when No is saved. Method will therefore fetch default config value because '0' equals false.
diff --git a/app/code/Magento/Store/Model/Store.php b/app/code/Magento/Store/Model/Store.php
@@ -531,8 +531,8 @@ public function setName($name)
     public function getConfig($path)
     {
         $data = $this->_config->getValue($path, ScopeInterface::SCOPE_STORE, $this->getCode());
-        if (!$data) {
-            $data = $this->_config->getValue($path, ScopeConfigInterface::SCOPE_TYPE_DEFAULT);
+        if ($data === null) {
+            $data = $this->_config->getValue($path);
         }
         return $data === false ? null : $data;
     }

Original file line number	Diff line number	Diff line change
`@@ -531,8 +531,8 @@ public function setName($name)`
`531`	`531`	`public function getConfig($path)`
`532`	`532`	`{`
`533`	`533`	`$data = $this->_config->getValue($path, ScopeInterface::SCOPE_STORE, $this->getCode());`
`534`		`- if (!$data) {`
`535`		`- $data = $this->_config->getValue($path, ScopeConfigInterface::SCOPE_TYPE_DEFAULT);`
	`534`	`+ if ($data === null) {`
	`535`	`+ $data = $this->_config->getValue($path);`
`536`	`536`	`}`
`537`	`537`	`return $data === false ? null : $data;`
`538`	`538`	`}`